From owner-cvs-all Sat Dec 15 14: 0:16 2001 Delivered-To: cvs-all@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id 8F3AA37B416; Sat, 15 Dec 2001 14:00:07 -0800 (PST) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id fBFLwWx91788; Sat, 15 Dec 2001 16:58:32 -0500 (EST) (envelope-from mike) Date: Sat, 15 Dec 2001 16:58:32 -0500 From: Mike Barcroft To: Luigi Rizzo Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011215165832.A77929@espresso.q9media.com> References: <200112141622.fBEGMg705939@freefall.freebsd.org> <20011215090750.A91194@citusc17.usc.edu> <20011215095930.A62613@iguana.aciri.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011215095930.A62613@iguana.aciri.org>; from luigi@FreeBSD.org on Sat, Dec 15, 2001 at 09:59:30AM -0800 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Luigi Rizzo writes: > There is something I do not follow. > > Over time we have gone through great pains to keep the code compatible > with a wide range of compilers (including K&R when possible, by > using __P() macros), and now people complain suggesting that instead > of supplying perfectly legal (K&R and ANSI) C prototypes to 3 > functions, which do not break anything and only increase code > portability towards possibly broken compilers, I should instead > compile the source tree with a version-specific compiler. > > Am i the only one who sees a contraddiction here ? Correct code should not be modified to cope with compiler bugs. In this case, your compiler is incorrectly requiring a prototype for main() in order to silence a diagnostic. This change should be backed out. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message