Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 08 May 1996 05:58:37 +0100
From:      "Gary Palmer" <gpalmer@FreeBSD.ORG>
To:        current@FreeBSD.ORG
Subject:   Recent commits
Message-ID:  <13429.831531517@palmer.demon.co.uk>

next in thread | raw e-mail | index | archive | help

Hi

I just did some cleanups to code in -current which should reduce the
number of compiler warnings produced by LINT by quite a bit. The
remaining warnings are left untouched (minus various warnings from the
filesystems which can be fixed but are being held back until the Lite
2 FS integration is complete):

../../netinet/in_proto.c:152: warning: initialization from incompatible pointer type

(Should be addressed by a patch John Hay is working on to get IPX in
 IP encapsulation working.)

../../i386/isa/if_eg.c:159: warning: can't inline call to `egread'
../../i386/isa/if_el.c:99: warning: can't inline call to `el_hardreset'
../../i386/isa/if_el.c:97: warning: can't inline call to `elread'
../../i386/isa/if_ix.c:159: warning: can't inline call to `ixintr_fr'
../../i386/isa/if_ix.c:157: warning: can't inline call to `ixintr_cx'
../../i386/isa/if_ix.c:158: warning: can't inline call to `ixintr_cx_free'
../../i386/isa/if_ix.c:160: warning: can't inline call to `ixintr_fr_copy'
../../i386/isa/if_ix.c:161: warning: can't inline call to `ixintr_fr_free'
../../i386/isa/pcvt/pcvt_drv.c:111: warning: can't inline call to `vt_registerdev'
../../i386/isa/scd.c:160: warning: can't inline call to `write_control'
../../i386/isa/seagate.c:1128: warning: assignment discards `volatile' from pointer target type
../../i386/isa/seagate.c:1198: warning: assignment discards `volatile' from pointer target type
../../i386/isa/syscons.h:192: warning: can't inline call to `draw_cursor'
../../i386/isa/syscons.h:190: warning: can't inline call to `move_crsr'
../../i386/linux/linux_sysvec.c:417: warning: initialization from incompatible pointer type
../../gnu/i386/isa/nic3008.c:946: warning: passing arg 1 of `timeout' from incompatible pointer type
../../gnu/i386/isa/nic3008.c:946: warning: passing arg 2 of `timeout' makes pointer from integer without a cast
../../gnu/i386/isa/nic3009.c:1238: warning: passing arg 1 of `timeout' from incompatible pointer type
../../gnu/i386/isa/nic3009.c:1238: warning: passing arg 2 of `timeout' makes pointer from integer without a cast

Several of the inline warnings only seem to occur with the LINT
kernel. Something is obviously annoying GCC in LINT to produce (some
of) these warnings for LINT but not for GENERIC.

The last 5 warnings (in linux_sysvec.c and nic300[89].c) are not so
easy to cure and I have left. The nic warnings can only be addressed
(easily) by casting the warnings away. A comment (presumably from
Bruce :-) ) next to the trouble spots says not to do that :-)

It would be nice if people with the relevant hardware (esp. the
authors/maintainers) could investigate the remaining warnings and
squash them... It is a nice goal (if a rather difficult one) to get
our kernel compiling cleanly with -Wall and every little helps...

Thanks

Gary
--
Gary Palmer                                            FreeBSD Core Team Member
FreeBSD - Turning PC's into workstations. See http://www.FreeBSD.ORG/ for info.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13429.831531517>