From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Sep 14 17:20:19 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 32D7F16A41F for ; Wed, 14 Sep 2005 17:20:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57B3643D6E for ; Wed, 14 Sep 2005 17:20:16 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8EHKGlo056498 for ; Wed, 14 Sep 2005 17:20:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8EHKGIK056497; Wed, 14 Sep 2005 17:20:16 GMT (envelope-from gnats) Resent-Date: Wed, 14 Sep 2005 17:20:16 GMT Resent-Message-Id: <200509141720.j8EHKGIK056497@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, onatan@gmail.com Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D989216A420 for ; Wed, 14 Sep 2005 17:19:56 +0000 (GMT) (envelope-from afarsec@012.net.il) Received: from mtaout3.012.net.il (mtaout3.012.net.il [84.95.2.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAB7043D55 for ; Wed, 14 Sep 2005 17:19:53 +0000 (GMT) (envelope-from afarsec@012.net.il) Received: from afarsec.com ([80.178.183.89]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with SMTP id <0IMT00249HCMU6C0@i_mtaout3.012.net.il> for FreeBSD-gnats-submit@freebsd.org; Wed, 14 Sep 2005 20:17:11 +0300 (IDT) Received: by afarsec.com (sSMTP sendmail emulation); Wed, 14 Sep 2005 20:12:33 +0300 Message-Id: <0IMT0024AHCMU6C0@i_mtaout3.012.net.il> Date: Wed, 14 Sep 2005 20:12:33 +0300 From: Jonathan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: mike@infonexus.com, scheidell@secnap.com Subject: ports/86132: Dependancy fixes for security/firewalk X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: onatan@gmail.com List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2005 17:20:19 -0000 >Number: 86132 >Category: ports >Synopsis: Dependancy fixes for security/firewalk >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Wed Sep 14 17:20:15 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jonathan >Release: FreeBSD 6.0-BETA4 i386 >Organization: Looking for one. >Environment: System: FreeBSD hasta.siempre.com 6.0-BETA4 FreeBSD 6.0-BETA4 #4: Fri Sep 9 00:07:43 IDT 2005 root@an.dan.te.com:/usr/obj/usr/src/sys/GENERIC i386 >Description: Michael Scheidell found and fixed two issues with libnet dependancies: 1. Firewalk port really depends on net/libnet-devel, but the check can be satisfied by net/libnet. 2. BIOCIMMEDIATE is undefined in some cases. The first problem is fixed by depending on an include file that is present only in net/libnet-devel. I couldn't reproduce the second problem, but the fix seems harmless so I'm including it. Comitter, don't forget to add Michael Scheidell scheidellsecnap.com to the "Additional FreeBSD Contributors" of the "FreeBSD Contributors" article. Thanks, Michael. >How-To-Repeat: Install net/libnet. Install security/firewalk Observe. >Fix: --- firewalk.diff begins here --- diff -urN firewalk.orig/Makefile firewalk/Makefile --- firewalk.orig/Makefile Mon Nov 15 00:26:10 2004 +++ firewalk/Makefile Wed Sep 14 19:22:07 2005 @@ -16,7 +16,7 @@ COMMENT= A remote firewall auditing tool BUILD_DEPENDS= ${LOCALBASE}/lib/libdnet.a:${PORTSDIR}/net/libdnet \ - ${LOCALBASE}/lib/libnet.a:${PORTSDIR}/net/libnet-devel + ${LOCALBASE}/include/libnet/libnet-types.h:${PORTSDIR}/net/libnet-devel RUN_DEPENDS= ${BUILD_DEPENDS} WRKSRC= ${WRKDIR}/Firewalk diff -urN firewalk.orig/files/patch-include:firewalk.h firewalk/files/patch-include:firewalk.h --- firewalk.orig/files/patch-include:firewalk.h Thu Jan 1 02:00:00 1970 +++ firewalk/files/patch-include:firewalk.h Wed Sep 14 19:21:19 2005 @@ -0,0 +1,13 @@ +--- include/firewalk.h.orig Wed Sep 14 19:19:27 2005 ++++ include/firewalk.h Wed Sep 14 19:20:37 2005 +@@ -41,6 +41,10 @@ + #include + #include + ++#ifndef BIOCIMMEDIATE ++#define BIOCIMMEDIATE _IOW('B',112,u_int) ++#endif ++ + #define FW_BANNER "Firewalk (c) 2002 Mike D. Schiffman \ + \nhttp://www.packetfactory.net/firewalk\n\ + for more information.\n" --- firewalk.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: