From owner-freebsd-fs@FreeBSD.ORG Fri May 14 11:53:24 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 465EF106567E; Fri, 14 May 2010 11:53:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1853C8FC26; Fri, 14 May 2010 11:53:24 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id BDC9446B86; Fri, 14 May 2010 07:53:23 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (localhost [IPv6:::1]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 88DB88A025; Fri, 14 May 2010 07:53:22 -0400 (EDT) Message-ID: <4BED346D.30905@FreeBSD.org> Date: Fri, 14 May 2010 07:30:53 -0400 From: John Baldwin User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <4BEB40EB.2030206@acm.poly.edu> <4BEBE634.4080102@FreeBSD.org> <20100513211750.GA2015@garage.freebsd.pl> In-Reply-To: <20100513211750.GA2015@garage.freebsd.pl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 14 May 2010 07:53:22 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-fs@freebsd.org Subject: Re: ZFS and __FreeBSD_version X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2010 11:53:24 -0000 Pawel Jakub Dawidek wrote: > On Thu, May 13, 2010 at 07:44:52AM -0400, John Baldwin wrote: >> Boris Kochergin wrote: >>> Hi. Can __FreeBSD_version be bumped if ZFS's userland API is ever >>> changed again? I got slightly bitten by the >>> state_to_name()-to-zpool_state_to_name() change from version 6 to >>> version 13 and would like a reliable way of keeping track of this type >>> of stuff in the future. Thanks. >> Yes, it should be bumped anytime the API changes. That is definitely a >> bug that it wasn't done properly last time. > > I must disagree here. libzfs API is for ZFS internal use only and is > subject to change at any time. This is true for OpenSolaris as well. > We, of course, can bump __FreeBSD_version if it helps, but one shouldn't > expect libzfs API being stable or there is any care taken to maintain > backward compatibility. Err, I did not say that the API should be stable, but if it is going to change we should bump __FreeBSD_version so that external software can cope via #ifdef's. Version bumps are cheap in stable branches. -- John Baldwin