From owner-freebsd-multimedia@FreeBSD.ORG  Fri Sep  5 00:59:30 2008
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8DB8A106566B
	for <freebsd-multimedia@freebsd.org>;
	Fri,  5 Sep 2008 00:59:30 +0000 (UTC)
	(envelope-from frtzkatz@yahoo.com)
Received: from web63007.mail.re1.yahoo.com (web63007.mail.re1.yahoo.com
	[69.147.96.218]) by mx1.freebsd.org (Postfix) with SMTP id 2A7688FC08
	for <freebsd-multimedia@freebsd.org>;
	Fri,  5 Sep 2008 00:59:30 +0000 (UTC)
	(envelope-from frtzkatz@yahoo.com)
Received: (qmail 24632 invoked by uid 60001); 5 Sep 2008 00:59:29 -0000
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com;
	h=X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type:Message-ID;
	b=ivhy95VIjNQZAn91l9kO6tHs6ZCYxqBFb/oAdgt2tVc2rs/wIIzTI5jg0ruu5CdsSMK3YmQtz/efA6ILrvAJLKn0Hd0nhtRBv31pR3fNmKh8iedqpFx9Z7dOtJrENJvQRZaKd+fVdx+wSYBeYXMxnmkyVwFctQJPuQ8m+vJu+O0=;
X-YMail-OSG: FFMc1FwVM1mUZHVl9JHNenKB6oYHKAm7xfVDlFzb2eNBwfopqDthlf4v7qMfVf5Gpmqgpz8Bue8vaERNH8BvLqq2FtfN0OB02Qa39fHGcsIdXNiA9SmO3syRxVxc5uw-
Received: from [71.104.221.209] by web63007.mail.re1.yahoo.com via HTTP;
	Thu, 04 Sep 2008 17:59:29 PDT
X-Mailer: YahooMailWebService/0.7.218.2
Date: Thu, 4 Sep 2008 17:59:29 -0700 (PDT)
From: Fritz Katz <frtzkatz@yahoo.com>
To: freebsd-multimedia@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Message-ID: <542052.24495.qm@web63007.mail.re1.yahoo.com>
Subject: Is this a bug? (in /usr/src/sys/dev/bktr/bktr_os.c )
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: frtzkatz@yahoo.com
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Sep 2008 00:59:30 -0000

In FreeBSD-7.0, /usr/src/sys/dev/bktr/bktr_os.c, line 469:

http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70#L469
__________

fail:
  if (bktr->res_irq)
     bus_release_resource(dev, SYS_RES_IRQ, bktr->irq_rid, bktr->res_irq);
  if (bktr->res_mem)
     bus_release_resource(dev, SYS_RES_IRQ, bktr->mem_rid, bktr->res_mem);
  return error;
__________

Shouldn't the type field for the second bus_release_resource be SYS_RES_MEMORY?  Would it cause a kernel panic if it were ever hit?  If it is a bug, it's probably been there for years.

Cheers,
-- Fritz Katz.