Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Mar 1995 16:53:00 -0500
From:      Garrett Wollman <wollman@halloran-eldar.lcs.mit.edu>
To:        Charlie Root <root@genabsd.netvision.net.il>
Cc:        freebsd-bugs@freefall.cdrom.com
Subject:   kern/269: machine hangs when closing ppp
Message-ID:  <9503222153.AA02029@halloran-eldar.lcs.mit.edu>
In-Reply-To: <199503222130.NAA15369@freefall.cdrom.com>
References:  <199503222019.WAA00227@genabsd.netvision.net.il> <199503222130.NAA15369@freefall.cdrom.com>

next in thread | previous in thread | raw e-mail | index | archive | help
<<On Wed, 22 Mar 1995 13:30:06 -0800, Charlie Root <root@genabsd.netvision.net.il> said:

> PPP ( /usr/sbin/ppp on tun0 ) works and copnnects fine.
> Howewer when i try to terminate connection with "close" command
> machine hangs ( no panic :-( ) .

I believe I know the source of the problem.  It's a bug I introduced
recently.

Try changing the code in net/radix.c:rn_walktree_from() which currently
looks like this:

                        /* if went up beyond last, stop */
                        if (rn->rn_b < lastb) {
                                stopping = 1;
                        }
to this:

                        /* if went up beyond last, stop */
                        if (rn->rn_b < lastb || (rn->rn_flags & RNF_ROOT)) {
                                stopping = 1;
                        }

and see if it helps.  (I can't test this right now because my tree is
broken for other reasons.)

-GAWollman

--
Garrett A. Wollman   | Shashish is simple, it's discreet, it's brief. ... 
wollman@lcs.mit.edu  | Shashish is the bonding of hearts in spite of distance.
Opinions not those of| It is a bond more powerful than absence.  We like people
MIT, LCS, ANA, or NSA| who like Shashish.  - Claude McKenzie + Florent Vollant



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9503222153.AA02029>