From owner-svn-src-projects@freebsd.org Tue Sep 22 20:26:23 2015 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76054A022D7 for ; Tue, 22 Sep 2015 20:26:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2ECC11F0C; Tue, 22 Sep 2015 20:26:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [10.192.0.157] (unknown [178.20.49.58]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id F32081AC14; Tue, 22 Sep 2015 22:26:18 +0200 (CEST) Subject: Re: svn commit: r288121 - projects/clang370-import/contrib/libc++/src/support Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_93E56BBB-8194-4E97-86D1-DFFD5C5A1AC9"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5.1 From: Dimitry Andric In-Reply-To: <1442949245.1224.229.camel@freebsd.org> Date: Tue, 22 Sep 2015 22:26:10 +0200 Cc: Warner Losh , Andrew Turner , src-committers , svn-src-projects@freebsd.org Message-Id: <77B76EA2-1C5A-4B35-BBAA-78F1ECAC9754@FreeBSD.org> References: <201509221734.t8MHYp0W052286@repo.freebsd.org> <00F42FF7-84D4-4C97-974F-C28DB36D4392@bsdimp.com> <9B0C3FE9-821B-470E-8AFC-F5B3DCE5B8F4@FreeBSD.org> <1442949245.1224.229.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2015 20:26:23 -0000 --Apple-Mail=_93E56BBB-8194-4E97-86D1-DFFD5C5A1AC9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 22 Sep 2015, at 21:14, Ian Lepore wrote: >=20 > On Tue, 2015-09-22 at 20:48 +0200, Dimitry Andric wrote: >> On 22 Sep 2015, at 20:37, Warner Losh wrote: ... >>> I=E2=80=99m not entirely sure that your =E2=80=98fix=E2=80=99 makes = things actually safe, even if it >>> seems to make them work today. I=E2=80=99ll have to study it more = closely. >>=20 >> Probably not 100% safe, since the stub functions are just = placeholders >> which aren't atomic at all. >=20 > This is confusing. The fact that these are stubs and aren't atomic at > all is the problem. There's no reason not to have real = implementations > on arm < v6, machine/atomic.h has all the common stuff implemented > already. They were not yet available in e.g. libgcc or libcompiler-rt, so I got link errors when clang was emitting calls to e.g. __atomic_add_fetch(). Andy has now fixed this with r288125, so I can revert this crude workaround. :-) -Dimitry --Apple-Mail=_93E56BBB-8194-4E97-86D1-DFFD5C5A1AC9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.28 iEYEARECAAYFAlYBuWgACgkQsF6jCi4glqNn1wCcCViQNz3OdOGHO0CdaGhBhmDD G0cAni2E9WRuIqAeH262p8jskdgFyrnC =PFaM -----END PGP SIGNATURE----- --Apple-Mail=_93E56BBB-8194-4E97-86D1-DFFD5C5A1AC9--