Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Apr 2017 14:15:53 +0000
From:      bugzilla-noreply@freebsd.org
To:        x11@FreeBSD.org
Subject:   [Bug 218811] graphics/libglapi: fails to build with bsdgrep
Message-ID:  <bug-218811-7141-YEDpg8d87r@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-218811-7141@https.bugs.freebsd.org/bugzilla/>
References:  <bug-218811-7141@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218811

Kyle Evans <bsdports@kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emaste@freebsd.org

--- Comment #2 from Kyle Evans <bsdports@kyle-evans.net> ---
(In reply to Jan Beich from comment #1)

D'oh. This is a trivially broken case; easily exceeds the maximum number of
line matches (MAX_LINE_MATCHES=3D32), then it infinitely loops because it s=
till
matches past that but it's not able to be inserted into 'matches,' causing =
my
failure mechanisms to fail because $bad.

I'll fix this in my -w empty broken review (https://reviews.freebsd.org/D10=
433)
version, because it's *not* straightforward to fix this on -HEAD since
procline() conflates matching a line with printing context. In the current
state of that patch, this will basically record 'st' and set lastmatches=3D=
0,
force a break at util.c:443, then at util.c:284 I'll throw in a loop that d=
oes
a procline() and printline() as long as we max out on matches.

Thanks for the report! =3D)

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218811-7141-YEDpg8d87r>