From owner-cvs-all  Fri Nov  8 11:23: 5 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9021737B401; Fri,  8 Nov 2002 11:23:03 -0800 (PST)
Received: from angelica.unixdaemons.com (angelica.unixdaemons.com [209.148.64.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BE72F43E6E; Fri,  8 Nov 2002 11:23:02 -0800 (PST)
	(envelope-from hiten@angelica.unixdaemons.com)
Received: from angelica.unixdaemons.com (hiten@localhost.unixdaemons.com [127.0.0.1])
	by angelica.unixdaemons.com (8.12.5/8.12.1) with ESMTP id gA8JMu5N037602;
	Fri, 8 Nov 2002 14:22:56 -0500 (EST)
X-Authentication-Warning: angelica.unixdaemons.com: Host hiten@localhost.unixdaemons.com [127.0.0.1] claimed to be angelica.unixdaemons.com
Received: (from hiten@localhost)
	by angelica.unixdaemons.com (8.12.5/8.12.1/Submit) id gA8JMtkI037601;
	Fri, 8 Nov 2002 14:22:55 -0500 (EST)
	(envelope-from hiten)
Date: Fri, 8 Nov 2002 14:22:55 -0500
From: Hiten Pandya <hiten@angelica.unixdaemons.com>
To: David Xu <davidxu@FreeBSD.ORG>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/i386/i386 vm86.c
Message-ID: <20021108142255.A31265@angelica.unixdaemons.com>
References: <200211080109.gA819GZG073240@repoman.freebsd.org> <003c01c286c3$44e8d710$ef01a8c0@davidwnt>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <003c01c286c3$44e8d710$ef01a8c0@davidwnt>; from davidxu@FreeBSD.ORG on Fri, Nov 08, 2002 at 09:07:55AM +0800
X-Operating-System: FreeBSD i386
X-Public-Key: http://www.pittgoth.com/~hiten/pubkey.asc
X-URL: http://www.unixdaemons.com/~hiten
X-PGP: http://pgp.mit.edu:11371/pks/lookup?search=Hiten+Pandya&op=index
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Fri, Nov 08, 2002 at 09:07:55AM +0800, David Xu wrote the words in effect of:
> 
> ----- Original Message ----- 
> From: "David Xu" <davidxu@FreeBSD.org>
> To: <cvs-committers@FreeBSD.org>; <cvs-all@FreeBSD.org>
> Sent: Friday, November 08, 2002 9:09 AM
> Subject: cvs commit: src/sys/i386/i386 vm86.c
> 
> 
> > davidxu     2002/11/07 17:09:16 PST
> > 
> >   Modified files:
> >     sys/i386/i386        vm86.c 
> >   Log:
> >   use critical_enter/exit to add a critical section around BIOS call,
> >   this unbreaks WITNESS.
> >   
> >   Pointed out by: jhb
> >   
> >   Revision  Changes    Path
> >   1.50      +9 -5      src/sys/i386/i386/vm86.c
> 
> I turned WITNESS all the time, but it hadn't reported any error message
> when spin lock was used.
> 
> David
> 

Should this information be added into mutex(9) manual page.  I remember
when I added this, after help from DES@ for the mutex profiling lock:

--% (kern_mutex.c)
static struct mtx mprof_mtx
MTX_SYSINIT(mprof, &mprof_mtx, "mutex profiling lock", MTX_SPIN | MTX_QUIET);
%--

--% (subr_witness.c)
static struct witness_order_list_entry order_lists[] = {
...
   { "mutex profiling lock", &lock_class_mtx_spin },
...
};
%--

Just a thought.
Cheers.

-- 
Hiten Pandya
hiten@unixdaemons.com, hiten@uk.FreeBSD.org, hiten@softweyr.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message