From owner-freebsd-ports@FreeBSD.ORG Tue Feb 8 13:29:37 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F289106567A for ; Tue, 8 Feb 2011 13:29:37 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id C72B58FC0C for ; Tue, 8 Feb 2011 13:29:36 +0000 (UTC) Received: by ewy24 with SMTP id 24so2854327ewy.13 for ; Tue, 08 Feb 2011 05:29:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=7xWldbsbdG02/Kr62Suh56kmeQuJBaL9yJIbyfqJziE=; b=k0WEFrmfIfqGBqMnFBrOAfH7xeL0/0LdBYc89dvWr2NcW6s2N9Imow+k14BTwXJF5B 7o5ZL0rjVwq3/0Pjbcm9rl49ggN+sJfKyUDgrMPlitvx5BAlZdpz11XkJWO3/KBY5lhd BuLHbUpuq4adUFB/zVz9yYUwwku0jJYw5tP8E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=XD2AVF3oi7yx130o+nuI0KHvqvIpoesSeUGQsO2F+jqurHBfBNrUq09FgeazzjeqGl L3r3g1oyqVwC6m+W6cLa0+FE3NcojNmBSccil6VM2nmgZQZlf6IHfSjCmacOyaF5kCRm 4wmoLGGZ/4XN1LxUIuCPFysG6VLyuGoUOkUlM= Received: by 10.213.108.69 with SMTP id e5mr1130913ebp.76.1297171775606; Tue, 08 Feb 2011 05:29:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.213.10.81 with HTTP; Tue, 8 Feb 2011 05:29:15 -0800 (PST) In-Reply-To: <4D513F7D.1040107@yandex.ru> References: <4D513F7D.1040107@yandex.ru> From: arrowdodger <6yearold@gmail.com> Date: Tue, 8 Feb 2011 16:29:15 +0300 Message-ID: To: Ruslan Mahmatkhanov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2011 13:29:37 -0000 On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanov wrot= e: > It shouldn't be listed in pkg-plist, because it will be removed > automatically on port deinstall. Well, if i 'make PREFIX=3D/home/arr/prefix install && make PREFIX=3D/home/arr/prefix deinstall' then this file is not deleted. You mea= n, it will be deleted if i install port without PREFIX? dirrm's for lib/nautilus and it's subdirectories should be dirrmtry's > actually, because it's doesn't created by tortoisehg-hgtk, but nautilus o= r > nautilus-plugins. Okay. Also consider to use: > > USE_GETTEXT=3D yes > INSTALLS_ICONS=3D yes > > In port's Makefile. > Should it be .if !defined(WITHOUT_NLS) USE_GETTEXT=3D yes .endif ? And what's the purpose of INSTALLS_ICONS? BLDDIR is defined but seems not used in Makefile. What it is for? > Oh, this is not needed now. I will remove that. =D0=A1=D0=BF=D0=B0=D1=81=D0=B8=D0=B1=D0=BE =D0=B7=D0=B0 =D0=BF=D0=BE=D0=B4= =D1=81=D0=BA=D0=B0=D0=B7=D0=BA=D0=B8.