From owner-freebsd-current@FreeBSD.ORG Sat Nov 13 16:37:36 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60A4E16A4CE; Sat, 13 Nov 2004 16:37:36 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C0C643D1D; Sat, 13 Nov 2004 16:37:35 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iADGbYOO025044; Sat, 13 Nov 2004 18:37:34 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 17583-01; Sat, 13 Nov 2004 18:37:33 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iADGbXX7025039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 13 Nov 2004 18:37:33 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id iADGbNab040243; Sat, 13 Nov 2004 18:37:23 +0200 (EET) (envelope-from ru) Date: Sat, 13 Nov 2004 18:37:23 +0200 From: Ruslan Ermilov To: Alexander Leidinger Message-ID: <20041113163723.GD40075@ip.net.ua> References: <6857.1100271323@critter.freebsd.dk> <20041112160137.X42945@beagle.kn.op.dlr.de> <1100274897.4194dcd1d67d6@netchild.homeip.net> <20041112171024.P42945@beagle.kn.op.dlr.de> <20041113092215.7a40f133@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HWvPVVuAAfuRc6SZ" Content-Disposition: inline In-Reply-To: <20041113092215.7a40f133@Magellan.Leidinger.net> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: Poul-Henning Kamp cc: Harti Brandt cc: current@freebsd.org Subject: Re: [TEST] make -j patch [take 2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Nov 2004 16:37:36 -0000 --HWvPVVuAAfuRc6SZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 13, 2004 at 09:22:15AM +0100, Alexander Leidinger wrote: > On Fri, 12 Nov 2004 17:11:37 +0100 (CET) > Harti Brandt wrote: >=20 > > On Fri, 12 Nov 2004 Alexander@Leidinger.net wrote: > >=20 > > > Zitat von Harti Brandt : > > > > > >> PK>>If yes: we have some ports which aren't -j safe, so this would v= iolate > > >> PK>>POLA. > > >> PK> > > >> PK>That is what "make -B" is for. > > >> > > >> Or .NOTPARALLEL > > > > > > I'm not talking about /usr/ports/category/port/Makefile, I'm talking = about > > > /usr/ports/category/port/work/tarball_dir/**/Makefile. We don't have > > > control about those Makefiles. > > > > > > As much as I like a flag in the Makefile of a port which indicates > > > that a port can't be build with -j, we don't have this and the last t= ime > > > this topic was discussed there was a strong objection to something li= ke > > > this. > > > > > > So this change may break procedures which worked so far. > >=20 > > How? If you specify -j on the port's make the -j gets passed down to al= l=20 > > sub-makes via MAKEFLAGS and they use it. The difference is just that th= e=20 > > overall number of jobs started is now limited by the original -j. >=20 > In my first mail I made an example where a portupgrade is in between two > make processes. make runs several portupgrade processes in parallel and > portupgrade calls make. AFAIK this doesn't result in in an invocation of > portupgrades child-make with -j. With phk's changes the child-make of > portupgrade uses the FIFO (at least this is what I read implicitly in > phk's response above). >=20 Yes. The presence of MAKE_JOBS_FIFO in environment causes the new make(1) to run in parallel mode when none of -j and -B options are specified (either explicitly or through the MAKEFLAGS envariable). I mentioned it to Poul-Henning that I believe it was a mistake, but he disagrees, and I don't want to argue about it. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --HWvPVVuAAfuRc6SZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBljhDqRfpzJluFF4RAt/LAJ4iRzGr6bFjelbvoiwehQ7HNpjeegCdEPbY T4hANXwPQiGxmlj9Bp6f41A= =l9zZ -----END PGP SIGNATURE----- --HWvPVVuAAfuRc6SZ--