From owner-svn-ports-all@FreeBSD.ORG Sat Nov 10 13:20:40 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AC459532; Sat, 10 Nov 2012 13:20:40 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1A63F8FC0C; Sat, 10 Nov 2012 13:20:39 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fw7so6380133vcb.13 for ; Sat, 10 Nov 2012 05:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=TFmYeKutECtZwxxOADdEge3xB1CQda+O+vjUuZWCCPc=; b=ELrcwTcXJlavPSIhGbDzF17p9kefSOfdXEhXwWhrgdUgaS9mO50Zhi1F52Ra2S6erZ C4WeT8JBtn4oZt4Vl83m4oMj43hCiQRAu7bfw5uCVkJZJFCmmS2NocsBmx42Qj7xiEYf sTESjSR9V/ufdhPBiFo9WXqhgRShxruNdl2hfqKv4wxJTn2RqgqqWVKL1la5aXxRyZRR odV4PBrKAEQFKDqpG3nwDe5ayVKuWh9hILp2vf+XPZpgGO2q16fqEvrAjibn2/SUeiH/ KQkuYzwdnNE6pXW2pNIkuv4Xs/+p7lRK+AnzbOItjJFEv/3u2sX1lTBg4Aau14KngX7/ 2SmA== Received: by 10.52.98.196 with SMTP id ek4mr13272288vdb.38.1352553639200; Sat, 10 Nov 2012 05:20:39 -0800 (PST) Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68]) by mx.google.com with ESMTPS id ct5sm1379602vdb.6.2012.11.10.05.20.38 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 10 Nov 2012 05:20:38 -0800 (PST) Sender: "Jason E. Hale" From: "Jason E. Hale" To: Alexey Dokuchaev Subject: Re: svn commit: r307265 - head/multimedia/xmms Date: Sat, 10 Nov 2012 08:20:37 -0500 Message-ID: <8250312.uWLkCNKtQT@mocha.verizon.net> User-Agent: KMail/4.8.4 (FreeBSD/9.0-RELEASE-p3; KDE/4.8.4; i386; ; ) In-Reply-To: <201211100944.qAA9i1aM075322@svn.freebsd.org> References: <201211100944.qAA9i1aM075322@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Nov 2012 13:20:40 -0000 On Saturday, November 10, 2012 09:44:01 Alexey Dokuchaev wrote: > Author: danfe > Date: Sat Nov 10 09:44:01 2012 > New Revision: 307265 > URL: http://svnweb.freebsd.org/changeset/ports/307265 > > Log: > Apparently, in some cases (per what I observe here) using empty(...) for > testing specific PORT_OPTIONS instead of kosher ! breaks the build. Fix > this. While here, move the test below the target. > That's because it should just be: .if empty(PORT_OPTIONS:MSIMD) The ${...} should be removed. The ! works too, but isn't any more kosher. > Approved by: maintainer > Feature safe: yes > > Modified: > head/multimedia/xmms/Makefile > > Modified: head/multimedia/xmms/Makefile > ============================================================================ > == --- head/multimedia/xmms/Makefile Sat Nov 10 09:41:47 2012 (r307264) +++ > head/multimedia/xmms/Makefile Sat Nov 10 09:44:01 2012 (r307265) @@ -111,8 > +111,8 @@ EXTRA_PATCHES= ${FILESDIR}/extra-patch-V > PLIST_SUB+= SPEC="@comment " > .endif > > -.if empty(${PORT_OPTIONS:MSIMD}) > post-extract: > +.if ! ${PORT_OPTIONS:MSIMD} > (cd ${WRKSRC}/Input/mpg123 && ${MV} decode_i586.s decode_i586.S && \ > cd ${WRKSRC}/Visualization/blur_scope && ${MV} blur_8.s blur_8.S); > ${REINPLACE_CMD} -e 's:\.s :.S :g' -e 's:\.s$$:.S:g' \ > @@ -129,7 +129,7 @@ pre-extract: > @${ECHO_MSG} "" > .endif > > -.if empty(${PORT_OPTIONS:MRUSXMMS_PATCHES}) > +.if ! ${PORT_OPTIONS:MRUSXMMS_PATCHES} > @${ECHO_MSG} "" > @${ECHO_MSG} "You can enable support for ID3v2 tags and CP1251" > @${ECHO_MSG} "encoding by setting the RUSXMMS_PATCHES option." -- Jason E. Hale - jhale@ FreeBSD Ports Committer KDE/FreeBSD Team