From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 26 09:20:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25A831065679 for ; Fri, 26 Jun 2009 09:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F1DC98FC2B for ; Fri, 26 Jun 2009 09:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n5Q9K192007820 for ; Fri, 26 Jun 2009 09:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n5Q9K1HG007819; Fri, 26 Jun 2009 09:20:01 GMT (envelope-from gnats) Resent-Date: Fri, 26 Jun 2009 09:20:01 GMT Resent-Message-Id: <200906260920.n5Q9K1HG007819@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Artemiev Igor Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 885EC106564A; Fri, 26 Jun 2009 09:15:48 +0000 (UTC) (envelope-from ai@kliksoft.ru) Received: from gate.kliksys.ru (gate.kliksys.ru [78.110.241.113]) by mx1.freebsd.org (Postfix) with ESMTP id 34A4E8FC1C; Fri, 26 Jun 2009 09:15:48 +0000 (UTC) (envelope-from ai@kliksoft.ru) Received: from [192.168.1.13] (helo=aef.kliksoft.ru) by gate.kliksys.ru with esmtp (Exim 4.68 (FreeBSD)) (envelope-from ) id 1MK7X9-000ISM-8s; Fri, 26 Jun 2009 13:15:47 +0400 Received: from aef.kliksoft.ru (localhost [127.0.0.1]) by aef.kliksoft.ru (8.14.3/8.14.3) with ESMTP id n5Q94cm7072107; Fri, 26 Jun 2009 13:04:38 +0400 (MSD) (envelope-from ai@kliksoft.ru) Received: (from ai@localhost) by aef.kliksoft.ru (8.14.3/8.14.3/Submit) id n5Q94bLX072106; Fri, 26 Jun 2009 13:04:37 +0400 (MSD) (envelope-from ai) Message-Id: <200906260904.n5Q94bLX072106@aef.kliksoft.ru> Date: Fri, 26 Jun 2009 13:04:37 +0400 (MSD) From: Artemiev Igor To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: osa@FreeBSD.org Subject: ports/136064: nginx uploadprogress module incorrect X-Progress-ID argument parsing (patch) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Artemiev Igor List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2009 09:20:02 -0000 >Number: 136064 >Category: ports >Synopsis: nginx uploadprogress module incorrect X-Progress-ID argument parsing (patch) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jun 26 09:20:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Artemiev Igor >Release: FreeBSD 7.2-STABLE i386 >Organization: KlikSys >Environment: System: FreeBSD one.kliksys.ru 7.2-STABLE FreeBSD 7.2-STABLE #7: Sun May 17 14:54:10 MSD 2009 root@one.kliksys.ru:/usr/obj/usr/src.7/sys/KERNEL i386 >Description: nginx 0.7.59. Requests like "GET /progress?X-Progress-ID=09e409d35e1b9dd1b5a2982709ac79eb&JsHttpRequest=12460060723877-script HTTP/1.1" cannot process properly, because module parse tracking_id as '09e409d35e1b9dd1b5a2982709ac79eb&JsHttpRequest=12460060723877-script' and instantly return "new Object({ 'state' : 'starting' })" >How-To-Repeat: Any trivial config from uploadprogress examples and request progress with X-Progress-ID and some args together >Fix: Patch below fix this problem: --- ngx_http_uploadprogress_module.c.orig 2009-06-26 08:34:21.000000000 +0000 +++ ngx_http_uploadprogress_module.c 2009-06-26 08:43:57.000000000 +0000 @@ -187,8 +187,9 @@ if (i) { start_p = p += 14; while (p < r->args.data + r->args.len) { - if (*p++ != '&') { - continue; + if (*p++ == '&') { + p--; + break; } } >Release-Note: >Audit-Trail: >Unformatted: