Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Oct 2005 19:20:37 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 85458 for review
Message-ID:  <200510171920.j9HJKbPn097130@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=85458

Change 85458 by rwatson@rwatson_peppercorn on 2005/10/17 19:20:18

	Audit the path passed to the acct() system call.  Annotate that we
	will need to add an argument token in the event that accounting is
	being disabled by the system call.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/kern_acct.c#5 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/kern_acct.c#5 (text+ko) ====

@@ -143,7 +143,8 @@
 	 * appending and make sure it's a 'normal'.
 	 */
 	if (uap->path != NULL) {
-		NDINIT(&nd, LOOKUP, NOFOLLOW, UIO_USERSPACE, uap->path, td);
+		NDINIT(&nd, LOOKUP, NOFOLLOW | AUDITVNPATH1, UIO_USERSPACE,
+		    uap->path, td);
 		flags = FWRITE | O_APPEND;
 		error = vn_open(&nd, &flags, 0, -1);
 		if (error)
@@ -165,6 +166,9 @@
 		}
 #ifdef MAC
 	} else {
+		/*
+		 * XXXAUDIT: Need to audit that accounting is being disabled.
+		 */
 		error = mac_check_system_acct(td->td_ucred, NULL);
 		if (error)
 			goto done2;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510171920.j9HJKbPn097130>