From owner-cvs-all  Sun Jun  9 20:14:50 2002
Delivered-To: cvs-all@freebsd.org
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id F2C2C37B40B; Sun,  9 Jun 2002 20:14:45 -0700 (PDT)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.3/8.12.3) with ESMTP id g5A3EjCV005318;
	Sun, 9 Jun 2002 20:14:45 -0700 (PDT)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.3/8.12.3/Submit) id g5A3EjTt005317;
	Sun, 9 Jun 2002 20:14:45 -0700 (PDT)
	(envelope-from dillon)
Date: Sun, 9 Jun 2002 20:14:45 -0700 (PDT)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200206100314.g5A3EjTt005317@apollo.backplane.com>
To: Mike Barcroft <mike@FreeBSD.ORG>
Cc: "Greg 'groggy' Lehey" <grog@FreeBSD.ORG>,
	cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/include pwd.h
References: <200206091939.g59JdJC05285@freefall.freebsd.org> <20020610004026.GD61036@wantadilla.lemis.com> <200206100049.g5A0nr1P004846@apollo.backplane.com> <20020609211243.C51371@espresso.q9media.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

:>
:>     For password related calls, the manual page also quite clearly states
:>     that <sys/types.h> must be included before <pwd.h>
:
:Yes, this was how old BSD/POSIX worked.  It's very different in new
:standards.  My changes won't affect any BSD software and only help
:portability.
:
:See my reply to Greg for more details.
:
:>     For these reasons I would strongly recommend either reverting this change
:>     and leaving at as it was, or removing <sys/types.h> from <pwd.h>
:>     and *NOT* adding weird #ifdef's for gid_t, uid_t, etc, as the manual
:>     page implies.
:
:I don't hear you complaining about those weird #ifdef's in
:<sys/types.h> :).  But seriously, Bruce's designed replacement will
:get rid of those once I've implemented it.
:
:Best regards,
:Mike Barcroft

    Which specification are you looking at?  I'm all for conforming to
    standards but this is new to me.

    In anycase, if you are going to remove the sys/types.h dependancy
    for pwd.h (and other headers) then you also need to document that in
    the related manual pages.

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message