Date: Sat, 19 May 2018 13:42:36 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333844 - head/sys/kern Message-ID: <20180519104236.GI6887@kib.kiev.ua> In-Reply-To: <1c2b35bf-4dbb-6aec-fdde-43f91edc8b69@selasky.org> References: <201805190413.w4J4DLag027044@repo.freebsd.org> <1c2b35bf-4dbb-6aec-fdde-43f91edc8b69@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 19, 2018 at 12:22:48PM +0200, Hans Petter Selasky wrote: > On 05/19/18 06:13, Matt Macy wrote: > > va_start(ap, fmt); > > - res = make_dev_credv(0, &dev, devsw, unit, cr, uid, gid, mode, fmt, ap); > > + DBGSET(res, make_dev_credv(0, &dev, devsw, unit, cr, uid, gid, mode, fmt, ap)); > > Is the make_dev_credv() called stubbed for non-debug builds? Apparently not. And my note about timer filter was also wrong. But this is indeed very unusual and error-prone macro, which seems to be removed in r333862.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180519104236.GI6887>