From owner-freebsd-i386@FreeBSD.ORG Sun Dec 16 02:40:02 2007 Return-Path: Delivered-To: freebsd-i386@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1A8A16A420 for ; Sun, 16 Dec 2007 02:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C864813C46A for ; Sun, 16 Dec 2007 02:40:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lBG2e2s3006637 for ; Sun, 16 Dec 2007 02:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lBG2e29G006636; Sun, 16 Dec 2007 02:40:02 GMT (envelope-from gnats) Resent-Date: Sun, 16 Dec 2007 02:40:02 GMT Resent-Message-Id: <200712160240.lBG2e29G006636@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-i386@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDABC16A418 for ; Sun, 16 Dec 2007 02:35:11 +0000 (UTC) (envelope-from dan@kulesh.obluda.cz) Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz [78.128.192.4]) by mx1.freebsd.org (Postfix) with ESMTP id 70D3613C442 for ; Sun, 16 Dec 2007 02:35:11 +0000 (UTC) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87]) by smtp1.kolej.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id lBG2YuTR068132 for ; Sun, 16 Dec 2007 03:34:57 +0100 (CET) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost. [127.0.0.1]) by kulesh.obluda.cz (8.14.2/8.14.2) with ESMTP id lBG2Yrdb001301 for ; Sun, 16 Dec 2007 03:34:53 +0100 (CET) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.14.2/8.14.1/Submit) id lBG2YrLm001300; Sun, 16 Dec 2007 03:34:53 +0100 (CET) (envelope-from dan) Message-Id: <200712160234.lBG2YrLm001300@kulesh.obluda.cz> Date: Sun, 16 Dec 2007 03:34:53 +0100 (CET) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: i386/118739: [ PATCH ] Allow the cpufreq/p4tcc driver to detach X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2007 02:40:03 -0000 >Number: 118739 >Category: i386 >Synopsis: [ PATCH ] Allow the cpufreq/p4tcc driver to detach >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-i386 >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Dec 16 02:40:02 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 6.3-PRERELEASE i386 >Organization: Obludarium >Environment: System: FreeBSD 6.3-PRERELEASE #18: Sun Dec 16 03:05:00 CET 2007 i386 src/sys/i386/cpufreq/p4tcc.c,v 1.11.2.1 2005/10/25 20:52:44 njl As far as I know the problem apply to current as well >Description: The p4tcc driver has no detach method with no aparent reason As p4tcc is not standalone driver but part of cpufreq suite it block reloading of the other cpufreq subdrivers >How-To-Repeat: kldunload cpufreq on hardware where p4tcc supported >Fix: Add the detach method. It mean: 1. set CPU to Automatic mode 2. deregister the driver 3. return NOERROR to upper layer --- sys/i386/cpufreq/p4tcc.c.ORIG 2007-12-16 02:49:30.000000000 +0100 +++ sys/i386/cpufreq/p4tcc.c 2007-12-16 03:08:12.000000000 +0100 @@ -72,6 +72,7 @@ static void p4tcc_identify(driver_t *driver, device_t parent); static int p4tcc_probe(device_t dev); static int p4tcc_attach(device_t dev); +static int p4tcc_detach(device_t dev); static int p4tcc_settings(device_t dev, struct cf_setting *sets, int *count); static int p4tcc_set(device_t dev, const struct cf_setting *set); @@ -83,6 +84,7 @@ DEVMETHOD(device_identify, p4tcc_identify), DEVMETHOD(device_probe, p4tcc_probe), DEVMETHOD(device_attach, p4tcc_attach), + DEVMETHOD(device_detach, p4tcc_detach), /* cpufreq interface */ DEVMETHOD(cpufreq_drv_set, p4tcc_set), @@ -201,6 +203,25 @@ } static int +p4tcc_detach(device_t dev) +{ + struct est_softc *sc; + struct cf_setting set; + int error; + + sc = device_get_softc(dev); + + /* + * Before we finish detach, switch to Automatic mode + */ + set.freq = 10000; + p4tcc_set(dev, &set); + + error = cpufreq_unregister(dev); + return (error); +} + +static int p4tcc_settings(device_t dev, struct cf_setting *sets, int *count) { struct p4tcc_softc *sc; >Release-Note: >Audit-Trail: >Unformatted: