From owner-cvs-all Fri Nov 8 13:43: 2 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 30CE537B401; Fri, 8 Nov 2002 13:43:01 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9826943E42; Fri, 8 Nov 2002 13:43:00 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id gA8Lgxpk032824; Fri, 8 Nov 2002 14:42:59 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Fri, 08 Nov 2002 14:42:52 -0700 (MST) Message-Id: <20021108.144252.89055445.imp@bsdimp.com> To: ru@FreeBSD.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/secure/lib/libcrypto Makefile.inc From: "M. Warner Losh" In-Reply-To: <200211081247.gA8Clpnv031449@repoman.freebsd.org> References: <200211081247.gA8Clpnv031449@repoman.freebsd.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <200211081247.gA8Clpnv031449@repoman.freebsd.org> Ruslan Ermilov writes: : secure/lib/libcrypto Makefile.inc : Log: : DON'T EVER PUT THIS BACK! : : Pointy hat to: obrien This commit appears to be correct from a technical point of view (we shouldn't have -I/usr/include in our tree at all, since that breaks cross building). Also, 1.28 diff doesn't match the commit message, so likely was made in error. Since it likely was in error, a better approach would be to have David back it out, or get his approval to correct what appears to me to be a commit made in error. However, it strikes me as being needlessly beligerent in tone. Such a tone is not condusive to the proper functioning of the project. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message