From owner-cvs-all Fri Mar 22 8:46: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 0F87B37B41B; Fri, 22 Mar 2002 08:45:55 -0800 (PST) Received: (from ru@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g2MGjs841132; Fri, 22 Mar 2002 08:45:54 -0800 (PST) (envelope-from ru) Message-Id: <200203221645.g2MGjs841132@freefall.freebsd.org> From: Ruslan Ermilov Date: Fri, 22 Mar 2002 08:45:54 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet ip_icmp.c ip_mroute.c ip_output.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG ru 2002/03/22 08:45:54 PST Modified files: sys/netinet ip_icmp.c ip_mroute.c ip_output.c Log: Prevent icmp_reflect() from calling ip_output() with a NULL route pointer which will then result in the allocated route's reference count never being decremented. Just flood ping the localhost and watch refcnt of the 127.0.0.1 route with netstat(1). Submitted by: jayanth Back out ip_output.c,v 1.143 and ip_mroute.c,v 1.69 that allowed ip_output() to be called with a NULL route pointer. The previous paragraph shows why this was a bad idea in the first place. MFC after: 0 days Revision Changes Path 1.69 +2 -2 src/sys/netinet/ip_icmp.c 1.72 +2 -1 src/sys/netinet/ip_mroute.c 1.153 +4 -6 src/sys/netinet/ip_output.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message