From owner-cvs-all Thu Sep 19 3:43:32 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2161237B401; Thu, 19 Sep 2002 03:43:31 -0700 (PDT) Received: from critter.freebsd.dk (esplanaden.cybercity.dk [212.242.40.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AF3343E42; Thu, 19 Sep 2002 03:43:30 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8JAhP31000985; Thu, 19 Sep 2002 12:43:26 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c In-Reply-To: Your message of "Thu, 19 Sep 2002 01:28:41 PDT." <200209190828.g8J8SfMv065815@freefall.freebsd.org> Date: Thu, 19 Sep 2002 12:43:25 +0200 Message-ID: <984.1032432205@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200209190828.g8J8SfMv065815@freefall.freebsd.org>, Julian Elischer writes: >julian 2002/09/19 01:28:41 PDT > > Modified files: > sys/kern uipc_mbuf.c > Log: > While well intentionned the check to see it there is a packet > header and return that length, was misguided. > > The check itself didn't take into account the fact that the > mbuf pointer pased in may be null, and the function is > defined specifically for cases where the caller knows what it wants. > Rather than fix the check I'm removing it as phk suggested. Not to mention that it failed to perform the other half of m_lenght()'s job: return a pointer to the last mbuf in the chain. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message