From owner-svn-src-head@freebsd.org Mon Feb 25 18:56:27 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D631B15125D3 for ; Mon, 25 Feb 2019 18:56:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B51873474 for ; Mon, 25 Feb 2019 18:56:26 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1551120976; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=B4f5HXNilzJsoP5q+oJKr+YbJToIMwnyFbOHgbcQ8mxkTsgX4eQkUvCRhN4ARG2cF+0Xq+jzDbWga 9pfH9BUMWB5g2iR+UriOsSAf+1j81W5jw/4fFTu5widwPc1iI5mhM7cVgkvN56oVUAnWH1YyfM8GYw Zw80P01dEN3QtFKCdF6JQZqrIwDD7T/C6kdvKHrzva7ZDR88Ikl3QKXWGbvFe3Jb/h5uKLCgij2uuY w6/NvITa9A+lrcE2udTrkRfxmSbuJN6vmekYTCRABR83UvMS/nbwzDYHV/eJTTjtIhmJMppCliYmiG yKN6o88jOi6xS9nWxPZBcFXhU2AT3Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=k4TGBLRA9oIGg8OHrFeMUbHWpzoLWEuuDlKhdZqwrCU=; b=VT+c6buHgwUn6wL9UiBKKI0JeL7/IR6gqhbu7SmzaGh1u3AjD6Rat0TziVTow1RAty1BU88V/e9c/ SFNxQPsdtQWMocPyEvskZ5jHI39X6SlIaU8q99efwEU+vrF1YVIC5ZgH7ykOxxgZTap487Ok+ZeFqq Cgu6pIpPW8I1VBRriyv72e+ECdkYu1Yk5YqdDXp5knl4nVxbYKLpFFMNmOenhdvv38GGF3hLsDh2l8 B/x9TLSZUS7IXgEJGoVBa2TC/nz7MLaFrMLpmeNy8TwXR6loRny/yBCX7tZjL2wFxLT17eU5UeB/cm MY1NilLqOEMalN16QUTX9ap+iIwR4Aw== ARC-Authentication-Results: i=1; outbound2.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=k4TGBLRA9oIGg8OHrFeMUbHWpzoLWEuuDlKhdZqwrCU=; b=ka+NhSRBNzDZStNa5C8ZWqlggVGaNGjmTjsrSRWGNhP97t7FrIIji2sfxSY/ekwap1CWO8AxLS1yc u4/IkZnK5IHS/D9T8ENHS1ON6M0V8utpDveFaflZEzwH87TEMs2ZNLYJ8YEk9qVbMmBHxDHNyUrbdz eku30j+binOkPsoDAeZEWcM7YbC626OI7ta2L2tNZIjK5XVUPw4yem7wT7XLUWaHaAOKzEC5AeVw5y 1uC6KU0ImRCxGNH789sJP2YkLBciBGpmOnzpCtg+5WArSqER97VQ8WypoWjLnIuXA6nGEn/hBBcmHu 6fmR7RaWiwktIhMg1AIxyce5hV04tqQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 05b037d1-392f-11e9-803b-31925da7267c X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA id 05b037d1-392f-11e9-803b-31925da7267c; Mon, 25 Feb 2019 18:56:14 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x1PIuD9q099317; Mon, 25 Feb 2019 11:56:13 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r344534 - head/cddl/contrib/opensolaris/tools/ctf/cvt From: Ian Lepore To: Leandro Lupori , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 25 Feb 2019 11:56:12 -0700 In-Reply-To: <201902251852.x1PIqlf7034853@repo.freebsd.org> References: <201902251852.x1PIqlf7034853@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4B51873474 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.978,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 18:56:27 -0000 On Mon, 2019-02-25 at 18:52 +0000, Leandro Lupori wrote: > Author: luporl > Date: Mon Feb 25 18:52:47 2019 > New Revision: 344534 > URL: https://svnweb.freebsd.org/changeset/base/344534 > > Log: > Increase ctfconvert buffer size > > Reviewed by: markj > Differential Revision: https://reviews.freebsd.org/D19353 > This is not a very good commit message. To be good, it should say why the size is being increased. If the commit had included the summary text from D19353 it would have been perfect. -- Ian > Modified: > head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > Modified: head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > ===================================================================== > ========= > --- head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon Feb > 25 18:41:16 2019 (r344533) > +++ head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon Feb > 25 18:52:47 2019 (r344534) > @@ -1268,7 +1268,7 @@ die_funcptr_create(dwarf_t *dw, Dwarf_Die die, > Dwarf_O > static intr_t * > die_base_name_parse(const char *name, char **newp) > { > - char buf[100]; > + char buf[256]; > char const *base; > char *c; > int nlong = 0, nshort = 0, nchar = 0, nint = 0; >