Date: Sat, 19 May 2018 09:49:39 -0700 From: Matthew Macy <mmacy@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333819 - in head/sys: conf modules/blake2 modules/crypto modules/drm2/i915kms modules/ipfilter Message-ID: <CAPrugNoQ_PDFDQUyjLHCLGEsBZLf3b833CEnuWsbFOTGB6KLLA@mail.gmail.com> In-Reply-To: <CAPrugNpCSmw9xPJnXWnwE4CkpWG3yYJ7DFk7JrVx1KY_7W2D9g@mail.gmail.com> References: <201805190004.w4J0419B099140@repo.freebsd.org> <CAPyFy2AxgBNBkoLzdeaimtiwJnA2qe9GkJ1drg9RT-crbUK0uQ@mail.gmail.com> <CAPrugNpCSmw9xPJnXWnwE4CkpWG3yYJ7DFk7JrVx1KY_7W2D9g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
As I suspected, we fix warnings on non-contrib code. These are only
used on contrib code.
-M
mmacy@anarchy [~/devel/upstream|9:46|26] find sys | xargs grep NO_WSELF_ASS=
IGN
sys/modules/ipfilter/Makefile:CWARNFLAGS.fil.c=3D
${NO_WSELF_ASSIGN} -Wno-unused
sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_lookup.c=3D
${NO_WSELF_ASSIGN} -Wno-unused
sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_proxy.c=3D
${NO_WSELF_ASSIGN} -Wno-unused
sys/conf/kern.mk:NO_WSELF_ASSIGN=3D -Wno-self-assign
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN}
-Wno-unused -I$S/contrib/ipfilter"
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN}
-Wno-unused -I$S/contrib/ipfilter"
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN}
-Wno-unused -Wno-error -I$S/contrib/ipfilter"
mmacy@anarchy [~/devel/upstream|9:47|27] find sys | xargs grep
NO_WSHIFT_COUNT_NEGATIVE
sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c=3D
${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW}
sys/conf/kern.mk:NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-shift-count-negative
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE}
${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath"
mmacy@anarchy [~/devel/upstream|9:47|28] find sys | xargs grep
NO_WSHIFT_COUNT_OVERFLOW
sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c=3D
${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW}
sys/conf/kern.mk:NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-shift-count-overflow
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE}
${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath"
On Sat, May 19, 2018 at 5:30 AM, Matthew Macy <mmacy@freebsd.org> wrote:
> Oops I=E2=80=99ll add a separate define for that
>
> On Sat, May 19, 2018 at 04:27 Ed Maste <emaste@freebsd.org> wrote:
>>
>> On 18 May 2018 at 20:04, Matt Macy <mmacy@freebsd.org> wrote:
>> > Author: mmacy
>> > Date: Sat May 19 00:04:01 2018
>> > New Revision: 333819
>> > URL: https://svnweb.freebsd.org/changeset/base/333819
>> >
>> > Log:
>> > Silence non-actionable warnings in vendor code
>> ...
>> > Modified: head/sys/conf/kern.mk
>> >
>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>> > --- head/sys/conf/kern.mk Fri May 18 23:42:08 2018
>> > (r333818)
>> > +++ head/sys/conf/kern.mk Sat May 19 00:04:01 2018
>> > (r333819)
>> > @@ -18,12 +18,13 @@ CWARNFLAGS?=3D -Wall -Wredundant-decls
>> > -Wnested-externs
>> > # a false positive.
>> > .if ${COMPILER_TYPE} =3D=3D "clang"
>> > NO_WCONSTANT_CONVERSION=3D -Wno-error-constant-conversion
>> > -NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-error-shift-count-negative
>> > -NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-error-shift-count-overflow
>> > -NO_WSELF_ASSIGN=3D -Wno-error-self-assign
>> > +NO_WSHIFT_COUNT_NEGATIVE=3D -Wno-shift-count-negative
>> > +NO_WSHIFT_COUNT_OVERFLOW=3D -Wno-shift-count-overflow
>> > +NO_WSELF_ASSIGN=3D -Wno-self-assign
>>
>> This silences the warning across the tree, not just vendor code.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPrugNoQ_PDFDQUyjLHCLGEsBZLf3b833CEnuWsbFOTGB6KLLA>