From owner-freebsd-ports@FreeBSD.ORG Tue Jan 30 01:30:25 2007 Return-Path: X-Original-To: freebsd-ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 83F9816A404 for ; Tue, 30 Jan 2007 01:30:25 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from spqr.komquats.com (S0106002078125c0c.gv.shawcable.net [24.108.150.192]) by mx1.freebsd.org (Postfix) with ESMTP id EC7F413C474 for ; Tue, 30 Jan 2007 01:30:24 +0000 (UTC) (envelope-from Cy.Schubert@komquats.com) Received: from cwsys.cwsent.com (cwsys [10.1.1.1]) by spqr.komquats.com (Postfix) with ESMTP id 825B84C5C3; Mon, 29 Jan 2007 17:32:02 -0800 (PST) Received: from cwsys (localhost [127.0.0.1]) by cwsys.cwsent.com (8.13.8/8.13.8) with ESMTP id l0U1Vxaj013854; Mon, 29 Jan 2007 17:32:02 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <200701300132.l0U1Vxaj013854@cwsys.cwsent.com> X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Jeremie Le Hen In-Reply-To: Message from Jeremie Le Hen of "Mon, 29 Jan 2007 23:26:55 +0100." <20070129222655.GL64768@obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 29 Jan 2007 17:31:59 -0800 Sender: Cy.Schubert@komquats.com Cc: freebsd-ports@FreeBSD.org Subject: Re: Vertical split patch in sysutils/screen X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Cy Schubert List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2007 01:30:25 -0000 In message <20070129222655.GL64768@obiwan.tataz.chchile.org>, Jeremie Le Hen wr ites: > Hi Cy, > > On Mon, Jan 29, 2007 at 08:04:09AM -0800, Cy Schubert wrote: > > A couple of comments. Something like this should be integrated into the > > base screen software. screen-devel@gnu.org or screen-users@gnu.org might be > > > a good place to start. That is the preferred approach. If the greater > > screen community does not feel this additional functionality is necessary > > and if we the FreeBSD community feel it is, I believe we could implement > > this. For something like this we should approach the GNU screen developers > > first. > > > > If we as a FreeBSD community decide to implement this outside of the GNU > > screen development community, I'd like to spend some time testing it. > > People are free to test it and let me know what they think. > > > > Firstly though, we should submit this to screen-devel@gnu.org. I would like > > > to be in the loop when you do submit it to them. > > Yes, I know the principle of upstream sources and I perfectly agree > with you. However, I think the patch have already been brought to ^^^^^ Is it possible they have not looked at it yet? > attention of screen-devel@gnu.org. The problem is that this patch > breaks some features, as described in the "Bugs" section of its > webpage [1] and have this not been adopted. Would you have a PR number or something that I can follow up on at gnu.org? Even better would be if someone could point me to any correspondence about this on the screen-devel mailing list archvies. The "Bugs" section concerns me. > > I fully understand you don't want to break screen. However I am > a user of this patch and I don't care about the broken features, > and so does a friend of mine. I supposes there might be other users > in this case, so I've made the patch. I'm sure others might be concerned about breakage even if you are not. > > I would understand if you didn't want to commit this. However if > you agree to commit it with a bug warning message, I can correct > my patch to add this message in which I will detail the broken > features. > > Please, let me know about your decision. I would rather not commit anything that would break the software, even if the user has the option of knowingly and intentionally breaking it through an option I provide. I don't know if the screen developers at gnu.org are unwilling to incorporate the patch in the base software. I'm not enamoured with the proposed patch. Unless the "Bugs" can be addressed I don't think it should be committed. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org e**(i*pi)+1=0