Date: Thu, 10 Jan 2019 14:30:54 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234822] [PATCH] sysutils/tmux: Add utf8proc option to Makefile Message-ID: <bug-234822-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234822 Bug ID: 234822 Summary: [PATCH] sysutils/tmux: Add utf8proc option to Makefile Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: mat@FreeBSD.org Reporter: dor.bsd@xm0.uk Assignee: mat@FreeBSD.org Flags: maintainer-feedback?(mat@FreeBSD.org) Created attachment 200987 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200987&action= =3Dedit sysutils/tmux: Add utf8proc option to Makefile This patch adds an option to compile tmux with utf8proc support, and defaul= ts it to on. This patch comes after I spent a while tracking down why I was having issues with various characters in the terminal and reading through https://github.com/tmux/tmux/issues/1057. Within that issue, there is a newtest.txt file which I was using to test tmux in a reliable way. The characters within the file are a "hugging face" and a "glowing star". T= hey are definitely printable characters. They're listed at emojipedia as: - https://emojipedia.org/glowing-star/ - https://emojipedia.org/hugging-face/ Tmux compiled without utf8proc will show the following when displaying the above file: Unicode 1f917, wcwidth() -1 input_top_bit_set 4 '\360\237\244\227' (width 1) Unicode 1f31f, wcwidth() -1 input_top_bit_set 4 '\360\237\214\237' (width 1) The wcwidth() lines are showing that wcwidth(3) failed to properly detect t= he character width, which leads to display issues later on. Once compiled against utf8proc, the above becomes: input_top_bit_set 4 '\360\237\244\227' (width 2) input_top_bit_set 4 '\360\237\214\237' (width 2) The character width is correctly detected and display issues no longer happ= en. I made this an option instead of just enabling it in the CONFIGURE_ARGS sin= ce maybe someone, somewhere depends on the odd wcwidth() behaviour. -David --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234822-7788>