Date: Wed, 16 Feb 2022 18:45:02 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261891] [NEW PORT] graphics/epsonscan2: scanner engine supporting many Seiko/Epson scanners Message-ID: <bug-261891-7788-wGo0OwueiU@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-261891-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-261891-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261891 Daniel Engberg <diizzy@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |diizzy@FreeBSD.org --- Comment #21 from Daniel Engberg <diizzy@FreeBSD.org> --- A few suggestions and questions for graphics/epsonscan2 While there's nothing wrong Porters Handbook recommends you to use DISTVERS= ION unless the framework can't determine version on its own. Ref: "3.1. Writing the Makefile" and "Table 2. Package Naming Examples" https://docs.freebsd.org/en/books/porters-handbook/book/ Please define LICENSE_FILE Reference: https://docs.freebsd.org/en/books/porters-handbook/makefiles/index.html#lic= enses-license_file Is it correct what we need both pcre and pcre2? Please define gettext-runtime dependency via USES=3D https://cgit.freebsd.org/ports/tree/Mk/Uses/gettext-runtime.mk Ref: https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gettext-runti= me Please define glib dependency using USES and USE_GNOME Example: https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile#n14 Reference: https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-gn= ome USES=3D for JPEG --> https://cgit.freebsd.org/ports/tree/Mk/Uses/jpeg.mk Not sure why it's missing in Porters Handbook CFLAGS --> USES=3D localbase https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase Ref: https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk LDFLAGS should probably be added? "6.3. Shared Libraries" in Porters Handbook %%DOCSDIR%%-1.0.0.0-1/ looks like a strange path Great work! Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-261891-7788-wGo0OwueiU>