Date: Mon, 25 May 2009 17:14:01 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: David Naylor <naylor.b.david@gmail.com> Cc: pgollucci@p6m7g8.com, Ion-Mihai Tetcu <itetcu@FreeBSD.org>, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Message-ID: <1243264441.37480.23.camel@pav.hide.vol.cz> In-Reply-To: <200905251011.16083.naylor.b.david@gmail.com> References: <20090522.195350.193746535.chat95@mac.com> <200905242007.06917.naylor.b.david@gmail.com> <1243194956.21797.4.camel@hood.oook.cz> <200905251011.16083.naylor.b.david@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-w1Bij2QuWb4oinS+sIaW
Content-Type: text/plain; charset="ISO8859-2"
Content-Transfer-Encoding: quoted-printable
David Naylor p=ED=B9e v po 25. 05. 2009 v 10:11 +0200:
> > > > > > > This part looks OK, I wonder if there's any reason t ain't li=
ke
> > > > > > > this now; Pav?
> > > > > > > -.if defined(MAKE_JOBS_NUMBER)
> > > > > > > +MAKE_JOBS_NUMBER?=3D `${SYSCTL} -n kern.smp.cpus`
> > > > > > > _MAKE_JOBS=3D -j${MAKE_JOBS_NUMBER}
> > > > > > > -.else
> > > > > > > -_MAKE_JOBS=3D -j`${SYSCTL} -n kern.smp.cpus`
> > > > > > > -.endif
> > > > > >
> > > > > > Wouldn't that mean an evaluation of the backtick command in eve=
ry
> > > > > > make(1) invocation? That would be highly undesirable.
> > >
> > > I don't believe that is the case.
> > >
> > > Here is what I get with the patch applied (MAKE_JOBS_NUMBER not defin=
ed):
> > > /usr/ports/editors/openoffice.org-3# make -V MAKE_JOBS_NUMBER -V
> > > _MAKE_JOBS `/sbin/sysctl -n kern.smp.cpus`
> > > -j`/sbin/sysctl -n kern.smp.cpus`
> > >
> > > Wouldn't this indicate that the backtick command is not being evaluat=
ed?
> >
> > Seems correct. But explain again, why you need this change?=20
>=20
> Not all ports use make but are concurrent capable and require different=20
> arguments to be passed which is why I needed to expose MAKE_JOBS_NUMBER=20
> (since it is just a number) and why _MAKE_JOBS was not an option. =20
Ok, how about doing a dirty hack and using ${_MAKE_JOBS:C/-j//} ?
Then we wouldn't have to modify bsd.port.mk ..
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
> Why do we need a film of "Lord of the Rings" when we have the book?
Because watching a cg enhanced Legolas fire a flaming arrow
into the heart of a warg is cool?
- asdf@asdf.com in rec.games.roguelike.angband
--=-w1Bij2QuWb4oinS+sIaW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkoatbkACgkQntdYP8FOsoJquACgz7Nt0dH3PIll0Qi2jBZsEDnf
3xAAn00JVcKQlj//ioHZnHKBBILBjyLp
=lbSh
-----END PGP SIGNATURE-----
--=-w1Bij2QuWb4oinS+sIaW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1243264441.37480.23.camel>