Date: Thu, 31 Mar 2016 20:09:42 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 206761] Kernel stack overflow in sysctl handler for kern.binmisc.add Message-ID: <bug-206761-8-Nfz7pU2dU5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-206761-8@https.bugs.freebsd.org/bugzilla/> References: <bug-206761-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206761 Sean Bruno <sbruno@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress CC| |sbruno@FreeBSD.org --- Comment #8 from Sean Bruno <sbruno@FreeBSD.org> --- Something like this has been suggested by sson@ to resolve these issues. W= hat do you guys think? diff --git a/sys/kern/imgact_binmisc.c b/sys/kern/imgact_binmisc.c index dd57717..39ca156 100644 --- a/sys/kern/imgact_binmisc.c +++ b/sys/kern/imgact_binmisc.c @@ -1,5 +1,5 @@ /*- - * Copyright (c) 2013-15, Stacey D. Son + * Copyright (c) 2013-16, Stacey D. Son * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -220,16 +220,17 @@ imgact_binmisc_add_entry(ximgact_binmisc_entry_t *xbe) { imgact_binmisc_entry_t *ibe; char *p; + int cnt; if (xbe->xbe_msize > IBE_MAGIC_MAX) return (EINVAL); - for(p =3D xbe->xbe_name; *p !=3D 0; p++) - if (!isascii((int)*p)) + for(cnt =3D 0, p =3D xbe->xbe_name; *p !=3D 0; cnt++, p++) + if (cnt >=3D IBE_NAME_MAX || !isascii((int)*p)) return (EINVAL); - for(p =3D xbe->xbe_interpreter; *p !=3D 0; p++) - if (!isascii((int)*p)) + for(cnt =3D 0, p =3D xbe->xbe_interpreter; *p !=3D 0; cnt++, p++) + if (cnt >=3D IBE_INTERP_LEN_MAX || !isascii((int)*p)) return (EINVAL); /* Make sure we don't have any invalid #'s. */ @@ -266,8 +267,6 @@ imgact_binmisc_add_entry(ximgact_binmisc_entry_t *xbe) /* Preallocate a new entry. */ ibe =3D imgact_binmisc_new_entry(xbe); - if (!ibe) - return (ENOMEM); SLIST_INSERT_HEAD(&interpreter_list, ibe, link); interp_list_entry_count++; --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206761-8-Nfz7pU2dU5>