From owner-svn-src-all@freebsd.org Thu Jun 14 10:50:54 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3659101BB58; Thu, 14 Jun 2018 10:50:54 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 57C94836C5; Thu, 14 Jun 2018 10:50:54 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 6C9B2260199; Thu, 14 Jun 2018 12:50:52 +0200 (CEST) Subject: Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core To: Bruce Evans Cc: Matthew Macy , Ryan Libby , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org, bde@freebsd.org References: <201806132330.w5DNUsrE043573@repo.freebsd.org> <20180614182603.U1417@besplex.bde.org> From: Hans Petter Selasky Message-ID: <4aa93c89-686e-e344-8e04-c34069e8516d@selasky.org> Date: Thu, 14 Jun 2018 12:50:36 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180614182603.U1417@besplex.bde.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 10:50:54 -0000 On 06/14/18 10:46, Bruce Evans wrote: > Are these macros for conversion of host (FreeBSD) dev_t's or target (Linux) > ones?  If for the host, then I don't see any reason not to use the host > APIs. > If for the target, then they shouldn't be used with the host dev_t.  If for > a mixture, then the translations are very confusing, especially when they > are the identity, and many more macros are needed to reduce the confusion. Hi, These values are only used inside the LinuxKPI for creating character devices. They have no exposure to user-space. Basically: Z = MKDEV(X,Y) MAJOR(Z) must be equal to X MINOR(Z) must be equal to Y --HPS