From owner-cvs-all@FreeBSD.ORG Sat Mar 17 00:39:46 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 08F4016A405 for ; Sat, 17 Mar 2007 00:39:46 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7]) by mx1.freebsd.org (Postfix) with SMTP id A5AF813C458 for ; Sat, 17 Mar 2007 00:39:45 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 23384 invoked by uid 399); 17 Mar 2007 00:39:45 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 17 Mar 2007 00:39:45 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <45FB38CD.90200@FreeBSD.org> Date: Fri, 16 Mar 2007 17:39:41 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0b2 (Windows/20070116) MIME-Version: 1.0 To: Pav Lucistnik References: <200703142021.l2EKLVr0024152@repoman.freebsd.org> In-Reply-To: <200703142021.l2EKLVr0024152@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Volker , cvs-ports@FreeBSD.org, Andrey Alakozov , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/apache13-modperl Makefile pkg-plist ports/www/apache13-modperl/files apache.in apache.sh X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2007 00:39:46 -0000 Pav Lucistnik wrote: > pav 2007-03-14 20:21:31 UTC > > FreeBSD ports repository > > Modified files: > www/apache13-modperl Makefile pkg-plist > Added files: > www/apache13-modperl/files apache.in > Removed files: > www/apache13-modperl/files apache.sh > Log: > - Fix rc script to have overridable apache_flags and apache_pidfile > > PR: ports/104465 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=104465 > Reported by: Andrey Alakozov > Submitted by: Volker > Approved by: maintainer timeout (apache; 5 months) > > - While here, modernize USE_RC_SUBR usage > > Revision Changes Path > 1.18 +2 -8 ports/www/apache13-modperl/Makefile > 1.1 +32 -0 ports/www/apache13-modperl/files/apache.in (new) > 1.4 +0 -32 ports/www/apache13-modperl/files/apache.sh (dead) > 1.7 +0 -1 ports/www/apache13-modperl/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/Makefile.diff?&r1=1.17&r2=1.18&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/files/apache.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/files/apache.sh > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/pkg-plist.diff?&r1=1.6&r2=1.7&f=h The changes to the Makefile and plist look good, thanks! Two problems with the rc.d script though. First, this: apache_flags="${apache_flags=''}" Is not necessary, or desirable. Second, since httpd is going to run as user www, the BEFORE statement should be dropped, and the REQUIRE should be changed to LOGIN. I'm happy to make these changes if no one objects. Doug -- This .signature sanitized for your protection