From owner-freebsd-ports  Mon May 31 12:10: 5 1999
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 21C1814F49
	for <freebsd-ports@FreeBSD.org>; Mon, 31 May 1999 12:10:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id MAA71727;
	Mon, 31 May 1999 12:10:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from bigphred.greycat.com (bigphred.greycat.com [207.173.133.2])
	by hub.freebsd.org (Postfix) with ESMTP id 3ABCB14EA9
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 May 1999 12:08:09 -0700 (PDT)
	(envelope-from dann@bigphred.greycat.com)
Received: (from root@localhost)
	by bigphred.greycat.com (8.9.3/8.9.3) id MAA70627;
	Mon, 31 May 1999 12:08:14 -0700 (PDT)
	(envelope-from dann)
Message-Id: <199905311908.MAA70627@bigphred.greycat.com>
Date: Mon, 31 May 1999 12:08:14 -0700 (PDT)
From: dann@greycat.com
Reply-To: dann@greycat.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/11962: ports/emulators/mtools build fails in floppyd.c
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         11962
>Category:       ports
>Synopsis:       ports/emulators/mtools build fails in floppyd.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 31 12:10:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Dann Lunsford
>Release:        FreeBSD 3.2-STABLE i386
>Organization:
Just me :-)
>Environment:
FreeBSD bigphred.greycat.com 3.2-STABLE FreeBSD 3.2-STABLE #8: Sat May 29 17:28:05 PDT 1999     root@bigphred.greycat.com:/usr/src/sys/compile/PHRED  i386
>Description:
Build of mtools (mtools-3.9.4-2703b.diff.gz, mtools-3.9.4.tar.gz, supped this
morning (31=May-1999)) fails in compiling floppyd.c.  

cc  -DHAVE_CONFIG_H -DSYSCONFDIR=\"/usr/local/etc\" -DCPU_i386 -DVENDOR_ -DOS_freebsd3_2 -DOS_freebsd3 -DOS_freebsd  -O -pipe -Wall -I.  -I.   -c floppyd.c
floppyd.c: In function `server_main_loop':
floppyd.c:671: `SIGCLD' undeclared (first use this function)
floppyd.c:671: (Each undeclared identifier is reported only once
floppyd.c:671: for each function it appears in.)
floppyd.c: In function `main':
floppyd.c:975: too few arguments to function `setpgrp'
gmake: *** [floppyd.o] Error 1
*** Error code 2

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
 

>How-To-Repeat:
Just try to build mtools: cd /usr/ports/emulators/mtools ; make all install clean.

>Fix:
Problem is a couple of remaining linuxisms; patch follows.
*** floppyd.c.original	Mon May 31 11:50:58 1999
--- floppyd.c	Mon May 31 11:57:38 1999
***************
*** 668,674 ****
  	/*
  	 * Ignore dead servers so no zombies should be left hanging.
  	 */
! 	signal(SIGCLD, SIG_IGN);
  
  	for (;;) {
  		int					new_sock;
--- 668,674 ----
  	/*
  	 * Ignore dead servers so no zombies should be left hanging.
  	 */
! 	signal(SIGCHLD, SIG_IGN);
  
  	for (;;) {
  		int					new_sock;
***************
*** 972,978 ****
  							 * Start a new session and group.
  							 */
  							setsid();
! 							setpgrp();
  #ifndef DEBUG
  							close(2);
  							open("/dev/null", O_WRONLY);
--- 972,978 ----
  							 * Start a new session and group.
  							 */
  							setsid();
! 							setpgrp(0,0);
  #ifndef DEBUG
  							close(2);
  							open("/dev/null", O_WRONLY);


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message