From owner-freebsd-ports-bugs@freebsd.org Fri May 1 19:22:01 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 958FB2DDCE5 for ; Fri, 1 May 2020 19:22:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49DMZK3796z41lX for ; Fri, 1 May 2020 19:22:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 539A52DDCE1; Fri, 1 May 2020 19:22:01 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 536092DDCE0 for ; Fri, 1 May 2020 19:22:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49DMZJ68gfz41lQ for ; Fri, 1 May 2020 19:22:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CEC95D3BC for ; Fri, 1 May 2020 19:22:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 041JM0Fc046906 for ; Fri, 1 May 2020 19:22:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 041JM0De046904 for ports-bugs@FreeBSD.org; Fri, 1 May 2020 19:22:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 246102] Mk/Uses/gnome.mk: INSTALLS_ICONS makes packages that will destroy icon-theme.cache files on deinstallation (gnome-post-icons: target generates unsuitable PLIST @rmtry) Date: Fri, 01 May 2020 19:22:00 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mandree@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2020 19:22:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246102 Bug ID: 246102 Summary: Mk/Uses/gnome.mk: INSTALLS_ICONS makes packages that will destroy icon-theme.cache files on deinstallation (gnome-post-icons: target generates unsuitable PLIST @rmtry) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: mandree@FreeBSD.org CC: gnome@FreeBSD.org, madpilot@FreeBSD.org, ports-bugs@FreeBSD.org I am hijacking and answering madpilot@s post to freebsd-ports today: Am 01.05.20 um 19:49 schrieb Guido Falsi: > hi, > > While testing an update to xfce ports I have got this error in poudriere: > > =3D>> Checking for extra files and directories > =3D>> Error: Files or directories removed: > share/icons/hicolor/icon-theme.cache > > And could not find any cause for it. > > This file should be managed by the INSTALLS_ICONS port variable, which > adds post-install and post-deinstall commands. > > My suspect is the post-deinstall command is not being run properly for > some reason causing this error. > > Could this be correct? How can I verify this? > You're hunting the wrong fault, and poudriere reports a genuine bug (which = is not in your package). Read again: the complaint is that the port deinstallation REMOVES (not: LEA= VES BEHIND) the prior icon-theme.cache. I've debugged this, the INSTALLS_ICONS from Mk/Uses/gnome.mk adds a @rmtry = (i. e. delete, but don't complain if missing) for the cache file, and topmost in the PLIST, so the deinstallation of ANY package using that macro will first update and then nuke the cache file. Proof below. Conclusion: Mk/Uses/gnome.mk is broken (in particular the gnome-post-icons: target). Here's how: # pkg -ddd delete xfce4-taskmanager # (was version 1.2.3): > [...] > DBG(1)[59116]> Deleting file: 'usr/local/share/locale/zh_TW/LC_MESSAGES/x= fce4-taskmanager.mo' > DBG(1)[59116]> Adding to deletion usr/local/share/locale/zh_TW/LC_MESSAGE= S/ > [1/1] Deleting files for xfce4-taskmanager-1.2.3... done > DBG(3)[59116]> Scripts: executing > --- BEGIN --- > set -- xfce4-taskmanager-1.2.3 > /usr/local/bin/gtk-update-icon-cache -q -f /usr/local/share/icons/hicolor= 2>/dev/null || /usr/bin/true > > Scripts: --- END --- > DBG(3)[59119]> Scripts: executing lua > --- BEGIN --- > file =3D pkg.prefixed_path("share/icons/hicolor/icon-theme.cache") > -- ignore the return value and the error > ret, err =3D os.remove(file) > Scripts: --- END --- and after that, /usr/local/share/icons/hicolor/icon-theme.cache is missing. Meaning that the deinstallation of ANY (but the last installed) package that uses INSTALLS_ICONS deletes the icon-theme.cache files in all directories w= here they had placed icons. --=20 You are receiving this mail because: You are on the CC list for the bug.=