Date: Fri, 12 Nov 2010 19:33:13 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r215194 - head/sys/dev/nfe Message-ID: <201011121933.oACJXEY2021193@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: yongari Date: Fri Nov 12 19:33:13 2010 New Revision: 215194 URL: http://svn.freebsd.org/changeset/base/215194 Log: Fix regression introduced in r215132. Caller always holds a driver lock before accessing mii, so locking is not needed here. Reported by: Rob Farmer (rfarmer <> predatorlabs dot net) Modified: head/sys/dev/nfe/if_nfe.c Modified: head/sys/dev/nfe/if_nfe.c ============================================================================== --- head/sys/dev/nfe/if_nfe.c Fri Nov 12 19:25:11 2010 (r215193) +++ head/sys/dev/nfe/if_nfe.c Fri Nov 12 19:33:13 2010 (r215194) @@ -817,8 +817,6 @@ nfe_miibus_statchg(device_t dev) sc = device_get_softc(dev); - NFE_LOCK(sc); - mii = device_get_softc(sc->nfe_miibus); ifp = sc->nfe_ifp; @@ -848,8 +846,6 @@ nfe_miibus_statchg(device_t dev) } NFE_WRITE(sc, NFE_TX_CTL, txctl); NFE_WRITE(sc, NFE_RX_CTL, rxctl); - - NFE_UNLOCK(sc); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011121933.oACJXEY2021193>