From owner-freebsd-drivers@FreeBSD.ORG Wed Jan 24 00:23:45 2007 Return-Path: X-Original-To: freebsd-drivers@freebsd.org Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C1D2616A402 for ; Wed, 24 Jan 2007 00:23:45 +0000 (UTC) (envelope-from daniel@roe.ch) Received: from calvin.roe.ch (calvin.roe.ch [213.144.141.26]) by mx1.freebsd.org (Postfix) with ESMTP id 8197613C455 for ; Wed, 24 Jan 2007 00:23:45 +0000 (UTC) (envelope-from daniel@roe.ch) Received: from d212-53-102-185.cust.tele2.ch ([212.53.102.185] helo=dragon.roe.ch) by calvin.roe.ch (envelope-from ) with ESMTPS (TLSv1:AES256-SHA:256) id 1H9Vud-0008ys-0l for freebsd-drivers@freebsd.org; Wed, 24 Jan 2007 01:22:51 +0100 Received: from roe by dragon.roe.ch (envelope-from ) with LOCAL id 1H9VvT-0001mi-00 for freebsd-drivers@freebsd.org; Wed, 24 Jan 2007 01:23:43 +0100 Date: Wed, 24 Jan 2007 01:23:43 +0100 From: Daniel Roethlisberger To: freebsd-drivers@freebsd.org Message-ID: <20070124002343.GA6214@dragon.roe.ch> Mail-Followup-To: freebsd-drivers@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.4i DomainKey-Status: (calvin.roe.ch) DomainKey-Result: (calvin.roe.ch) Subject: New OMNIKEY CardMan 4040 driver - review request X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2007 00:23:45 -0000 I've written a driver for the OMNIKEY CardMan 4040 pccard smartcard reader using the vendor's Linux driver as a reference. My driver seems to work for me. However, since this is my first attempt at writing a FreeBSD device driver, I guess I'm bound to have missed some issues. I would be grateful if some more experienced driver hackers could take a look at it and let me know about whatever can be improved in some way. Especially I'd like comments about callout / locking interaction in this driver. Here is a diff against RELENG_6_1: http://dragon.roe.ch/~roe/cmx/cmx-6.1-20070124.diff.gz There's no manual page yet, but other than that, the driver should be complete. -Dan -- Daniel Roethlisberger