From owner-svn-src-all@freebsd.org Fri Apr 6 01:34:51 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AB98F93C5D; Fri, 6 Apr 2018 01:34:51 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 06FBC7C60B; Fri, 6 Apr 2018 01:34:50 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f43.google.com with SMTP id u62-v6so6708124ita.5; Thu, 05 Apr 2018 18:34:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=Z1/A8z/8vW91CPaXvqowPIxeSPR0pqN5W9sTaTZ/lpM=; b=RfxYNgf8E5P9e74LKkmDV0/A6YCLJyCchmqbKVjx+md6WVTYlJrG94BSpM4CGKYGIy N1+4/JJXotltpH1cW8VHF6GUxE5GkRRuIjbhPxbqlBFSihcchin3LOD2dmav7dfES+iI KUzCN2oBY7W1s7BT3Q2ZxdIA3TGc7lM1ucYaZ0rH274Yy/sM5AF7GyWxIxVzqY9TceGV IkQTbuCsDs4uC0+HgevSP0bSH6Ub4bbLW2W9O13Ho7uxCY0pHxViOvw8e/MyK7olefdJ ujUh/duL6Utmut+aCCViGUcsWaDZwQBYsb8F7rYNUN1kbYko7r96ehE3mBYTPxMiW+WE F/KQ== X-Gm-Message-State: ALQs6tD+gB5ldMeBg2vAiEj4upQhTNor4YTQgeZrP+ijxdj8TP81aSKi P4VvGHev4tjUXKq7npJNyU5ssTav X-Google-Smtp-Source: AIpwx48LMA9k0Xo9bT0aH33gzMazgIFBYe4duwsb2KuO/7cuXNKFlICapQwhiAjq/hVAexBGzQl4sw== X-Received: by 2002:a24:428f:: with SMTP id i137-v6mr16767391itb.33.1522978490141; Thu, 05 Apr 2018 18:34:50 -0700 (PDT) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com. [209.85.223.180]) by smtp.gmail.com with ESMTPSA id b72-v6sm5000433iti.17.2018.04.05.18.34.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 18:34:49 -0700 (PDT) Received: by mail-io0-f180.google.com with SMTP id q84so32825432iod.10; Thu, 05 Apr 2018 18:34:49 -0700 (PDT) X-Received: by 10.107.168.78 with SMTP id r75mr22651924ioe.143.1522978489737; Thu, 05 Apr 2018 18:34:49 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.62.19 with HTTP; Thu, 5 Apr 2018 18:34:49 -0700 (PDT) In-Reply-To: References: <201804051356.w35Duexg022529@repo.freebsd.org> <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org> From: Conrad Meyer Date: Thu, 5 Apr 2018 18:34:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid To: Allan Jude Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 01:34:51 -0000 Yep, exactly =E2=80=94 md_intel was tasting the md(4) device. md_intel invokes g_raid_md_get_label() early on in its taste routine. On Thu, Apr 5, 2018 at 6:29 PM, Allan Jude wrote: > On 2018-04-05 21:20, Conrad Meyer wrote: >> On Thu, Apr 5, 2018 at 6:08 PM, Allan Jude wrote= : >>> On 2018-04-05 09:56, Sean Bruno wrote: >>>> Author: sbruno >>>> Date: Thu Apr 5 13:56:40 2018 >>>> New Revision: 332070 >>>> URL: https://svnweb.freebsd.org/changeset/base/332070 >>>> >>>> Log: >>>> Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. >>>> >>>> ... >>> I might be missing something here, but it seems like you didn't actuall= y >>> change the side of >>> ... >>> struct md_s >> >> The md side can be as small as it likes. It's the caller who needs to >> provide the large buffer, for other providers of the GEOM::ident >> attribute. >> >>> And I don't see where the destination buffer went from 24 bytes to a >>> larger value. >> >> Check the change in md_intel.c. >> >> Best, >> Conrad >> > > Right, but md_intel.c is for intel BIOS raid. > > I don't see the change that increased the size of the buffer in the > caller from 24 bytes to something more useful? > > Or was it md_intel tasting the md(4) device? > > -- > Allan Jude