From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 15 08:21:06 2015 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9480FADF for ; Mon, 15 Jun 2015 08:21:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7E8DEDD9 for ; Mon, 15 Jun 2015 08:21:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5F8L6Sb071285 for ; Mon, 15 Jun 2015 08:21:06 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 200428] [patch] allow custom PATCH_PATH_SEPARATOR defined in port Date: Mon, 15 Jun 2015 08:21:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mat@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 08:21:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200428 --- Comment #5 from Mathieu Arnold --- (In reply to Olli Hauer from comment #4) > The issue I'm talking about is not for existing patches, it is for new ones. > > In case the file or path contains '_' the resulting patch file name is > nonsense. > > E.g. original file path is ${WRKSRC}modules/ssl/ssl_engine_init.c > > cd www/apache24 > > make patch > > rm files/patch-modules__ssl__ssl_engine_init.c > > make makepatch > > > svn stat files/ | grep init.c > ! files/patch-modules__ssl__ssl_engine_init.c > ? files/patch-modules_ssl_ssl__engine__init.c Ok, as it is an existing patch, have you tried not rm'ing the file before running makepatch ? If you *do not* rm the existing patches before running makepatch, it should put the patches in the current file and not in the new canonical name. If *that* is not working correctly, please tell us. Now, the canonical name of a patch, is _ is replaced by __ and / is replaced by _. -- You are receiving this mail because: You are on the CC list for the bug.