From owner-svn-ports-all@freebsd.org  Wed Jul  1 15:59:47 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8FB58355A3E;
 Wed,  1 Jul 2020 15:59:47 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 49xmBq3DYxz4gr7;
 Wed,  1 Jul 2020 15:59:47 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 609CC14BB2; Wed,  1 Jul 2020 15:59:47 +0000 (UTC)
Date: Wed, 1 Jul 2020 15:59:47 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Jason Bacon <bacon4000@gmail.com>
Cc: Li-Wen Hsu <lwhsu@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r540967 - in head/net/lualdap: . files
Message-ID: <20200701155947.GA50158@FreeBSD.org>
References: <202007011406.061E6Cxt041119@repo.freebsd.org>
 <20200701151607.GA6554@FreeBSD.org>
 <a5b62c40-e342-829c-24fc-9f8b4a37874d@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a5b62c40-e342-829c-24fc-9f8b4a37874d@gmail.com>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jul 2020 15:59:47 -0000

On Wed, Jul 01, 2020 at 10:28:15AM -0500, Jason Bacon wrote:
> On 2020-07-01 10:16, Alexey Dokuchaev wrote:
> > On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote:
> >> New Revision: 540967
> >> URL: https://svnweb.freebsd.org/changeset/ports/540967
> >>
> >> Log:
> >>    Update to 1.2.5
> >>    
> >> ...
> >> -MAKE_ARGS+=	LUA_LIBDIR="${LUA_LIBDIR}" \
> >> -		LUA_INC="${LUA_INCDIR}" \
> >> -		OPENLDAP_LIB="-L${LOCALBASE}/lib -lldap" \
> >> -		LUA_VERSION_NUM="${LUA_VER_STR}0" \
> >> -		CC="${CC}"
> >> +MAKE_ARGS+=	CPPFLAGS="-I${LOCALBASE}/include -I${LUA_INCDIR}" \
> >> +		LDFLAGS="-L${LOCALBASE}/lib" \
> >> +		CC=${CC}
> > Dropping quotes around ${CC} can potentially break things and also
> > had contributed some unnecessary repo churn. :(
> 
> I would have thought ${CC} is always just the compiler name sans
> flags/whitespace, but danfe is correct. There's one case in Mk that
> would call for quotes:

Another thing which rings the bell is ccache which can be invoked as
"ccache compiler [compiler options]", thus CC="ccache compiler".

./danfe