Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 08 Feb 2020 03:14:36 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 243971] [NEW PORT] www/py-gdown: Download files from google drive
Message-ID:  <bug-243971-7788-k3KiEONbmI@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-243971-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-243971-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243971

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(FreeBS
                   |                            |D@ShaneWare.Biz)
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
                 CC|                            |FreeBSD@ShaneWare.Biz
            Summary|New port www/py-gdown:      |[NEW PORT] www/py-gdown:
                   |python module and cli cmd   |Download files from google
                   |to download files from      |drive
                   |google drive                |
             Status|New                         |Open

--- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> ---
gdown depends on "requests[socks]" , the "requests" packages
extras_require=3Dsocks[...] dependency list [1].

When declaring dependencies for packages that declare dependencies on
package[extras] form, the port must depend on those dependencies directly [=
2]

requests[socks] is currently defined in requests setup.py [3] as:

  extras_require { 'socks': ['PySocks>=3D1.5.6, !=3D1.5.7'], }

If, in fact, "socks" functionality in gdown is *not* compulsory, but instead
OPTIONAL, then gdown should list and declare the socks dependency in
extras_require (optional dependencies), not install_requires (compulsory
dependencies)

gdown, could for example do:

  install_requires =3D requests (compulsory base requests functionality)
  extras_require =3D requests[socks], or directly on pysocks (optional socks
support)


[1] gdown:setup.py: install_requires=3D['filelock', 'requests[socks]', 'six=
',
'tqdm'],
[2] https://wiki.freebsd.org/Python/PortsPolicy#Transitive_Dependencies
[3] requests:setup.py:extras_requite =3D { ... , 'socks': ['PySocks>=3D1.5.=
6,
!=3D1.5.7'], ... }

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243971-7788-k3KiEONbmI>