From owner-freebsd-acpi@FreeBSD.ORG Tue May 11 17:34:44 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D04E116A4CE; Tue, 11 May 2004 17:34:44 -0700 (PDT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4154443D1D; Tue, 11 May 2004 17:34:44 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.10/8.12.9) with ESMTP id i4C0YhOd087729; Tue, 11 May 2004 18:34:43 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 11 May 2004 18:35:38 -0600 (MDT) Message-Id: <20040511.183538.13771005.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <20040511151428.P77557@root.org> References: <20040507231846.F52653@root.org> <20040508164334.GA3217@dhcp01.pn.xcllnt.net> <20040511151428.P77557@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: acpi@freebsd.org cc: arch@freebsd.org Subject: Re: New ACPI blacklist format X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2004 00:34:45 -0000 In message: <20040511151428.P77557@root.org> Nate Lawson writes: : On Sat, 8 May 2004, Marcel Moolenaar wrote: : > On Fri, May 07, 2004 at 11:28:15PM -0700, Nate Lawson wrote: : > : > *snip* : > : > > static struct acpi_table_desc Abit_BP6[] = { : > > { "FACP", "AWARD", "AWRDACPI", "<=", "30302e31", "", "", "" }, : > > }; : > > static struct acpi_table_desc AMI_INT[] = { /* 01/18/00 */ : > > { "FACP", "AWARD", "", "<=", "10", "", "", "" }, : > > { "DSDT", "", "", "<=", "5", "", "", "" }, : > > }; : > > static struct acpi_table_desc Compaq_ViperII[] = { : > > { "FACP", "COMPAQ", "VIPER II", "<=", "06040000", "PTL", "<=", "000F4240" }, : > > }; : > : > *snip* : > : > If space is a concern, you can enable (i.e. compile-in) quirks by : > using kernel options, like: : > : > options ACPI_QUIRK_ABIT_BP6 : > : > and : > : > #ifdef ACPI_QUIRK_ABIT_BP6 : > static struct acpi_table_desc Abit_BP6[] = { : > { "FACP", "AWARD", "AWRDACPI", "<=", "30302e31", "", "", "" }, : > }; : > #endif : > : > You put all three of them in GENERIC and people can add or remove them : > from their own kernel configuration to fit their needs (and save space). : > If the quirks are in MI files, then this also avoids that i386 quirks : > end up in amd64 or ia64 kernels. : : There will be about 100-300 of these. :) All the more reason to have them in a form that can easily be subset and takes the tedium (== error possibilities) out of the loop :-) Warner