From owner-freebsd-bugs  Sat May 17 23:40:04 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA13704
          for bugs-outgoing; Sat, 17 May 1997 23:40:04 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA13698;
          Sat, 17 May 1997 23:40:02 -0700 (PDT)
Resent-Date: Sat, 17 May 1997 23:40:02 -0700 (PDT)
Resent-Message-Id: <199705180640.XAA13698@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, nw1@cs.wustl.edu
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id XAA13495;
          Sat, 17 May 1997 23:34:19 -0700 (PDT)
Message-Id: <199705180634.XAA13495@hub.freebsd.org>
Date: Sat, 17 May 1997 23:34:19 -0700 (PDT)
From: nw1@cs.wustl.edu
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: misc/3615: Error in /usr/src/lib/libc/gen/sigsetops.c
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         3615
>Category:       misc
>Synopsis:       Error in /usr/src/lib/libc/gen/sigsetops.c
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 17 23:40:01 PDT 1997
>Last-Modified:
>Originator:     Nanbor Wang
>Organization:
Washington University
>Release:        3.0-current
>Environment:
FreeBSD number.wustl.edu 3.0-CURRENT FreeBSD 3.0-CURRENT #0: Wed Feb 26 00:22:44 CST 1997     root@number.wustl.edu:/usr/src/sys/compile/EXTRA_SLOW_PENTIUM  i386

>Description:
In file /usr/src/lib/libc/gen/sigsetops.c, the sigismember() is implemented as:

int
sigismember(set, signo)
        const sigset_t *set;
        int signo;
{
        return ((*set & ~sigmask(signo)) != 0);
}

Which is not correct.  (In /usr/include/signal.h, if _ANSI_SOURCE is defined,
it is defined as:

#define sigismember(set, signo) ((*(set) & (1 << ((signo) - 1))) != 0)

This is correct.)

>How-To-Repeat:
Try play with it and you know.  I have compared it with Solaris's behaviors
and am absolutely sure this is a bug.

>Fix:
int
sigismember(set, signo)
        const sigset_t *set;
        int signo;
{
        return ((*set & sigmask(signo)) != 0);
}

>Audit-Trail:
>Unformatted: