From owner-freebsd-bugs@FreeBSD.ORG  Mon Jul 30 06:01:49 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AED181065670;
	Mon, 30 Jul 2012 06:01:49 +0000 (UTC)
	(envelope-from listlog2011@gmail.com)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 944D48FC1A;
	Mon, 30 Jul 2012 06:01:49 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6U61jml043168;
	Mon, 30 Jul 2012 06:01:48 GMT (envelope-from listlog2011@gmail.com)
Message-ID: <50162349.8070209@gmail.com>
Date: Mon, 30 Jul 2012 14:01:45 +0800
From: David Xu <listlog2011@gmail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1;
	rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Bruce Evans <brde@optusnet.com.au>
References: <201207272150.q6RLo9ew012879@freefall.freebsd.org>
	<501482CD.6050708@gmail.com>
	<CAGH67wQYCf6N0hF4Hru63snCxVoPjBmLgjyPkVBRT7q7+gcqbQ@mail.gmail.com>
	<50148F42.20105@gmail.com> <5014A64A.3010106@gmail.com>
	<20120729191243.D2283@besplex.bde.org>
In-Reply-To: <20120729191243.D2283@besplex.bde.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Garrett Cooper <yanegomi@gmail.com>, freebsd-bugs@FreeBSD.org,
	davidxu@FreeBSD.org
Subject: Re: kern/170203: [kern] piped dd&#39; s don&#39; t behave sanely
 when dealing with a fifo
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: davidxu@FreeBSD.org
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jul 2012 06:01:49 -0000

On 2012/7/29 17:16, Bruce Evans wrote:
> On Sun, 29 Jul 2012, David Xu wrote:
>
>>> I have just written two quick-and-dirty test cases:
>>>
>>> http://people.freebsd.org/~davidxu/patch/fifopipe/fifo_selectread.c
>>> http://people.freebsd.org/~davidxu/patch/fifopipe/fifo_selectwrite.c
>>>
>>> without patch for kernel code,  a child process will print out 
>>> "timeout".
>
>> I have updated patch, the patch fixed lost-notification bug for 
>> select():
>> http://people.freebsd.org/~davidxu/patch/fifopipe/kernel_pipe2.diff
>
> So it was a bug in the new pipe code.
>
My patch only fixes the lost of notification, it is not intent to fix 
the problems
in  /usr/src/tools/regression/poll tests, I think those are other more 
detailed
implementation problems.

> The test seemed to work under FreeBSD-~5.2 but was hard to configure.
> It gave lots of abort traps.  One was for the big buffer.  This is too
> big for -current too, and causes a mysterious abort trap with no core,
> before exec.  truss, gdb and bde were confused.
>
I am sorry that you were confused, I have updated fifo_selectread.c, it 
had a large buffer
which is a left-over from my another local program, I have removed the 
buffer.

> Bruce
>
Regards,
David Xu