From owner-freebsd-current@FreeBSD.ORG Thu Sep 30 05:17:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D211C16A4CE for ; Thu, 30 Sep 2004 05:17:32 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 601F143D4C for ; Thu, 30 Sep 2004 05:17:32 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i8U5GVmG052731; Thu, 30 Sep 2004 01:16:31 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i8U5GUF2052728; Thu, 30 Sep 2004 01:16:31 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 30 Sep 2004 01:16:30 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Dikshie In-Reply-To: <20040930044835.GA911@ppk.itb.ac.id> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@freebsd.org Subject: Re: -BETA6 panic with xorp multicast routing daemon X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2004 05:17:32 -0000 On Thu, 30 Sep 2004, Dikshie wrote: > I got my -BETA6 panic when run xorp routing daemon. > Panic: mutex Giant not owned at /usr/src/sys/netinet/ip_mroute.c:2672 > > I've included: > options MROUTING > options PIM > for multicast purpose and: > > options KDB > options KDB_TRACE > options DDB #Enable the kernel debugger > options DDB_NUMSYM > options GDB > > for debugging. but my box didnt save core to /var/crash. > any suggestions ? >From the nature of the panic, it sounds like you're running with NET_WITH_GIANT, debug.mpsafenet=0 in loader.conf, or that the setting has been forced by running with a kernel component that relies on Giant over the network stack? Try the attached patch, please. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research Index: ip_mroute.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/ip_mroute.c,v retrieving revision 1.108 diff -u -r1.108 ip_mroute.c --- ip_mroute.c 27 Aug 2004 18:33:07 -0000 1.108 +++ ip_mroute.c 30 Sep 2004 05:00:17 -0000 @@ -598,20 +598,23 @@ static void ip_mrouter_reset(void) { + int callout_flag; + bzero((caddr_t)mfctable, sizeof(mfctable)); bzero((caddr_t)nexpire, sizeof(nexpire)); pim_assert = 0; mrt_api_config = 0; - callout_init(&expire_upcalls_ch, CALLOUT_MPSAFE); + callout_flag = debug_mpsafenet ? CALLOUT_MPSAFE : 0; + callout_init(&expire_upcalls_ch, callout_flag); bw_upcalls_n = 0; bzero((caddr_t)bw_meter_timers, sizeof(bw_meter_timers)); - callout_init(&bw_upcalls_ch, CALLOUT_MPSAFE); - callout_init(&bw_meter_ch, CALLOUT_MPSAFE); + callout_init(&bw_upcalls_ch, callout_flag); + callout_init(&bw_meter_ch, callout_flag); - callout_init(&tbf_reprocess_ch, CALLOUT_MPSAFE); + callout_init(&tbf_reprocess_ch, callout_flag); } static struct mtx mrouter_mtx; /* used to synch init/done work */