From owner-p4-projects@FreeBSD.ORG  Thu Jul  6 22:14:32 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3EE1516A4E5; Thu,  6 Jul 2006 22:14:32 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1B07916A4DD
	for <perforce@freebsd.org>; Thu,  6 Jul 2006 22:14:32 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E221E43D45
	for <perforce@freebsd.org>; Thu,  6 Jul 2006 22:14:31 +0000 (GMT)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k66MEVKm053896
	for <perforce@freebsd.org>; Thu, 6 Jul 2006 22:14:31 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k66MEVgR053893
	for perforce@freebsd.org; Thu, 6 Jul 2006 22:14:31 GMT
	(envelope-from jb@freebsd.org)
Date: Thu, 6 Jul 2006 22:14:31 GMT
Message-Id: <200607062214.k66MEVgR053893@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 100807 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jul 2006 22:14:32 -0000

http://perforce.freebsd.org/chv.cgi?CH=100807

Change 100807 by jb@jb_freebsd2 on 2006/07/06 22:14:11

	I don't understand how this code compiles in current.
	
	For sun4v, the bus accessor type was changed from u_int32_t
	to u_int8_t and now this code (rightly) won't compile. It 
	shouldn't compile in current either.

Affected files ...

.. //depot/projects/dtrace/src/sys/dev/acpica/acpi_pci.c#4 edit

Differences ...

==== //depot/projects/dtrace/src/sys/dev/acpica/acpi_pci.c#4 (text+ko) ====

@@ -264,8 +264,10 @@
 acpi_pci_probe(device_t dev)
 {
 
+#ifdef DOODAD
 	if (pcib_get_bus(dev) < 0)
 		return (ENXIO);
+#endif
 	if (acpi_get_handle(dev) == NULL)
 		return (ENXIO);
 	device_set_desc(dev, "ACPI PCI bus");