Date: Sat, 26 Aug 1995 17:18:24 -0700 From: David Greenman <davidg@Root.COM> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-commiters@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c Message-ID: <199508270018.RAA16641@corbin.Root.COM> In-Reply-To: Your message of "Sun, 27 Aug 95 08:44:09 %2B1000." <199508262244.IAA19856@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>>It was added to fix the abuse of install -s to install non binary files. >>Installs specifically says in its man page it is for installing binary >>files. > >I decided not to object again, because install's error handling is so >poor that a little more won't be noticed. E.g., strip() returns void >after unlinking the file, so install usually "succeeds" after unlinking >the bad target. It may unlink the source ... > >It should exit after unlinking the file; it should exit if unlink() >fails ... > >I plan to change install to leave the original file alone for longer, so >that it can clean for failures up without touching the target. Now it >unlinks the target very early, so it can't restore the target, and >when strip() fails the file being unlinked is usually a copy of the >source. I'm open to suggestions. Please advise...I don't personally have an opinion. If you want the change backed out, then it should be backed out of both trees. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508270018.RAA16641>