From owner-freebsd-current Thu Jul 29 1: 1:58 1999 Delivered-To: freebsd-current@freebsd.org Received: from herring.nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (Postfix) with ESMTP id 7594414C3F; Thu, 29 Jul 1999 01:01:53 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id JAA98474; Thu, 29 Jul 1999 09:04:59 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Thu, 29 Jul 1999 09:04:59 +0100 (BST) From: Doug Rabson To: Garrett Wollman Cc: Doug Rabson , current@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include resource.h src/sys/alpha/pci pcibus.c src/sys/i386/include resource.h src/sys/pci pci.c pci_compat.c In-Reply-To: <199907281434.KAA07938@khavrinen.lcs.mit.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 28 Jul 1999, Garrett Wollman wrote: > < said: > > > Add support for SYS_RES_DENSE and SYS_RES_BWX resource types. These are > > equivalent to SYS_RES_MEMORY for x86 but for alpha, the rman_get_virtual() > > address of the resource is initialised to point into either dense-mapped > > or bwx-mapped space respectively, allowing direct memory pointers to be > > used to device memory. > > This makes me rather uncomfortable, on several fronts. I believe it > would be more appropriate to add a type argument to rman_get_virtual. To make that work, rman_get_virtual would need to be a BUS interface method. One possible alternative is to use SYS_RES_MEMORY with a set of flags to specify how the memory is to be accessed. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message