From owner-freebsd-current@FreeBSD.ORG  Tue Mar 18 19:29:35 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0A17930E
 for <current@freebsd.org>; Tue, 18 Mar 2014 19:29:35 +0000 (UTC)
Received: from mail-wi0-x22c.google.com (mail-wi0-x22c.google.com
 [IPv6:2a00:1450:400c:c05::22c])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9738B18C
 for <current@freebsd.org>; Tue, 18 Mar 2014 19:29:34 +0000 (UTC)
Received: by mail-wi0-f172.google.com with SMTP id hi5so4164931wib.17
 for <current@freebsd.org>; Tue, 18 Mar 2014 12:29:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:date:message-id:subject:from:to:content-type;
 bh=jZM0ls8K3pyKtJ9fiGN6jESB/dDS394f35rlbCQvQTI=;
 b=VOs8vZqMxGNl0EZYvqX+hHl/RSZIZ07I+1eyfOBTul08W0F3qijKVKkCeqIV5VcADq
 GJXj+HvpM09x9WRBLZ0dK9L1mJPZlhVpqMBeD7f9brVwV6BAOFvpo3k6F0jCbSfHpaDp
 CLI/gYbkHuL7Qzypuv88re8XfklhoLZVd6mobyhoCc+hsLfvcdT9i7KoWVyAgkKlF4dk
 4FI7AFzQyugjLnEu7eTmj4m6t6YHdrBLQWQ9GSyC+qVruLmn3s1+S6md+yCvjrpEmdH3
 WCU6JzBejzTgPSVjvaOr/lMUsmD5wwHxjHwkwutJml58noHfatWdZC9rY9apkJFfyra4
 p7wg==
MIME-Version: 1.0
X-Received: by 10.180.101.40 with SMTP id fd8mr15648951wib.1.1395170972227;
 Tue, 18 Mar 2014 12:29:32 -0700 (PDT)
Sender: maksim.yevmenkin@gmail.com
Received: by 10.227.113.207 with HTTP; Tue, 18 Mar 2014 12:29:32 -0700 (PDT)
Date: Tue, 18 Mar 2014 12:29:32 -0700
X-Google-Sender-Auth: p7ktD_3t-2Vpn2TULGjHeWRsl3I
Message-ID: <CAFPOs6pAfrmN8U0jWn+oTLDWg+-U+hjLr5fuq-Fw1Q_jrmqc0Q@mail.gmail.com>
Subject: [rfc] /dev/devstat permissions patch
From: Maksim Yevmenkin <emax@freebsd.org>
To: "current@freebsd.org" <current@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Mar 2014 19:29:35 -0000

hello,

would anyone object to the following patch?

==

Index: subr_devstat.c
===================================================================
--- subr_devstat.c (revision 263311)
+++ subr_devstat.c (working copy)
@@ -503,7 +503,7 @@
  mtx_assert(&devstat_mutex, MA_NOTOWNED);
  if (!once) {
  make_dev_credf(MAKEDEV_ETERNAL | MAKEDEV_CHECKNAME,
-    &devstat_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0400,
+    &devstat_cdevsw, 0, NULL, UID_ROOT, GID_WHEEL, 0444,
     DEVSTAT_DEVICE_NAME);
  once = 1;
  }

==

i'm not sure why /dev/devstat has such restrictive permissions. can
someone please explain the reason for it? having gstat(8) require
super-user privilege seems like an overkill me. iostat(8) and
systat(1) do not require super-user privileges to work.

and, yes, i know i can override permissions with /etc/devfs.conf, just
curious what are we protecting from in /dev/devstat

thanks,
max