From owner-freebsd-net@FreeBSD.ORG  Fri Oct  5 15:18:04 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 344931065670;
	Fri,  5 Oct 2012 15:18:04 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id 826B38FC22;
	Fri,  5 Oct 2012 15:18:00 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q95FHx5u052560;
	Fri, 5 Oct 2012 19:17:59 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q95FHxOW052559;
	Fri, 5 Oct 2012 19:17:59 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Fri, 5 Oct 2012 19:17:59 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Ermal Lu?i <eri@FreeBSD.org>
Message-ID: <20121005151759.GT34622@glebius.int.ru>
References: <20121005114716.GP34622@FreeBSD.org>
	<CAPBZQG0Z0Hc-DCQoyZGEwLMXB4wSsEZhyoy9zNDuXe8P8LBoQA@mail.gmail.com>
	<20121005131228.GQ34622@glebius.int.ru>
	<CAPBZQG2PSNK_YmwpKDue_ZorNRXW0Zag2LW=p+OAk08nopy7LQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <CAPBZQG2PSNK_YmwpKDue_ZorNRXW0Zag2LW=p+OAk08nopy7LQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: net@FreeBSD.org, zec@FreeBSD.org, bjoern@FreeBSD.org
Subject: Re: [PATCH] resolve byte order mess in ip_input/ip_output/pfil(9)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Oct 2012 15:18:04 -0000

On Fri, Oct 05, 2012 at 05:05:16PM +0200, Ermal Lu?i wrote:
E> > E> speaking of pf(4) side of things please do not loose the VIMAGE calls!
E> >
E> > Yeah, can you explain please why do we need them here? The pfil hooks
E> > are always run already in some defined VNET context, don't they?
E> >
E> 
E> from my testing at the time these were needed otherwise you will get issues.
E> I do not remember the details but i put those there because were required.
E> There is no overhead as well from leaving those there.

Well, we need to understand things we are doing, and not put code blindly.
AFAIU, any packet filter is called in already defined VNET context.

Let me put Marko and Bjoern to Cc and ask their help.

Marko, Bjoern,

we are speaking about CURVNET_SET()/CURVNET_RESTORE() in pf_check*
functions in pf_ioctl.c. Do we need them? IMO, any pfil(9) hook should
be called in defined context.

-- 
Totus tuus, Glebius.