Date: Wed, 28 Jul 2010 23:47:11 -0700 (PDT) From: Doug Barton <dougb@FreeBSD.org> To: Mark Linimon <linimon@lonesome.com> Cc: jhell <jhell@DataIX.net>, skv@FreeBSD.org, ports@FreeBSD.org, perl@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk) Message-ID: <alpine.BSF.2.00.1007282321490.1718@qbhto.arg> In-Reply-To: <20100729041455.GA21455@lonesome.com> References: <20100718223830.GA10338@lonesome.com> <4C43B4A5.5080104@FreeBSD.org> <4C44D01C.70704@p6m7g8.com> <alpine.BSF.2.00.1007192043010.1694@qbhto.arg> <4C451F06.8020106@p6m7g8.com> <alpine.BSF.2.00.1007192102470.1694@qbhto.arg> <4C453409.8000201@p6m7g8.com> <alpine.BSF.2.00.1007192254160.1725@qbhto.arg> <20100729041455.GA21455@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
--0-2081216686-1280386054=:1718
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Wed, 28 Jul 2010, Mark Linimon wrote:
> These are the results that I get on my home machine:
> ----------------------------------------------------------------------
>
> Here is my /etc/make.conf:
>
> OPENSSH_OVERWRITE_BASE=yes
> WITH_APACHE2=yes
> X11BASE=${LOCALBASE}
>
> USE_LOCAL_MK= yes
This is dubious, but unlikely to cause the problems you're seeing.
> Here is the diff I am using for bsd.port.mk (well, the relevant parts):
I would have thought that the obvious patch was the one attached, to
simply remove the code that we would like to remove in the final
version, including bsd.per.mk; and that you would not want any other
diffs in Mk/* while you were testing this.
> Index: bsd.port.mk
> ===================================================================
> RCS file: /home/FreeBSD/pcvs/ports/Mk/bsd.port.mk,v
> retrieving revision 1.643
> diff -u -r1.643 bsd.port.mk
> --- bsd.port.mk 15 Jul 2010 14:48:50 -0000 1.643
> +++ bsd.port.mk 20 Jul 2010 23:19:42 -0000
> -#.if defined(USE_PERL5) || defined(USE_PERL5_BUILD) || defined(USE_PERL5_RUN) || defined(PERL_CONFIGURE) || defined(PERL_MODBUILD)
> +.if defined(USE_PERL5) || defined(USE_PERL5_BUILD) || defined(USE_PERL5_RUN) || defined(WANT_PERL) || defined(PERL_CONFIGURE) || defined(PERL_MODBUILD)
> .include "${PORTSDIR}/Mk/bsd.perl.mk"
> -#.endif
> +.endif
When I asked you what was necessary to test this, you said all that was
necessary was to define _PERL_REFACTORING_COMPLETE. Clearly this, and
the other patch below are significant departures from those
instructions, which means I'll have to re-run all of my tests, and all
the time I already put into this (and likely the time that pgolluci put
into it as well) was completely wasted.
> .if defined(USE_PHP)
> .include "${PORTSDIR}/Mk/bsd.php.mk"
> @@ -2102,9 +2103,9 @@
> .include "${PORTSDIR}/Mk/bsd.sdl.mk"
> .endif
>
> -#.if defined(USE_PERL5) || defined(USE_PERL5_BUILD) || defined(USE_PERL5_RUN) || defined(PERL_CONFIGURE) || defined(PERL_MODBUILD)
> +.if defined(USE_PERL5) || defined(USE_PERL5_BUILD) || defined(USE_PERL5_RUN) || defined(WANT_PERL) || defined(PERL_CONFIGURE) || defined(PERL_MODBUILD)
> .include "${PORTSDIR}/Mk/bsd.perl.mk"
> -#.endif
> +.endif
>
> .if defined(USE_PHP)
> .include "${PORTSDIR}/Mk/bsd.php.mk"
>
> ----------------------------------------------------------------------
>
> There is no diff on my bsd.perl.mk.
>
> ----------------------------------------------------------------------
>
> Unlike the last time I looked at this (20091109, with some other debug
> code inserted), the errors above seem tractable. However, I really
> would like to understand why I get errors and other installs don't.
I will test again with the attached patch plus the other 2 changes you
have above and then publish the details of how I tested. Then you and/or
Phil can take it from there.
Doug
--
Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/
Computers are useless. They can only give you answers.
-- Pablo Picasso
--0-2081216686-1280386054=:1718
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=perl-refactoring.diff
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.BSF.2.00.1007282347110.1718@qbhto.arg>
Content-Description:
Content-Disposition: attachment; filename=perl-refactoring.diff
SW5kZXg6IGJzZC5wZXJsLm1rDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL2hvbWUvcGN2cy9wb3J0cy9Nay9ic2QucGVybC5tayx2DQpy
ZXRyaWV2aW5nIHJldmlzaW9uIDEuMTcNCmRpZmYgLXUgLXIxLjE3IGJzZC5w
ZXJsLm1rDQotLS0gYnNkLnBlcmwubWsJMTUgSnVsIDIwMTAgMTQ6NDg6NTAg
LTAwMDAJMS4xNw0KKysrIGJzZC5wZXJsLm1rCTI5IEp1bCAyMDEwIDA2OjMw
OjI4IC0wMDAwDQpAQCAtODAsMTAgKzgwLDYgQEANCiBQZXJsX1ByZV9JbmNs
dWRlPQkJCWJzZC5wZXJsLm1rDQogUEVSTF9JbmNsdWRlX01BSU5UQUlORVI9
CXBlcmxARnJlZUJTRC5vcmcNCiANCi0jIFhYWCB0byByZW1haW4gdW5kZWZp
bmVkIHVudGlsIGFsbCBwb3J0cyB0aGF0IHJlcXVpcmUgUGVybCBhcmUgZml4
ZWQNCi0jIHRvIHNldCBvbmUgb2YgdGhlIGNvbmRpdGlvbmFscyB0aGF0IGZv
cmNlIHRoZSBpbmNsdXNpb24gb2YgYnNkLnBlcmwubWsNCi0uaWYgZGVmaW5l
ZChfUEVSTF9SRUZBQ1RPUklOR19DT01QTEVURSkNCi0NCiBQRVJMX1ZFUlNJ
T04/PQk1LjEwLjENCiANCiAuaWYgIWRlZmluZWQoUEVSTF9MRVZFTCkgJiYg
ZGVmaW5lZChQRVJMX1ZFUlNJT04pDQpAQCAtMTEzLDggKzEwOSw2IEBADQog
UEVSTDU9CQkke0xPQ0FMQkFTRX0vYmluL3Blcmwke1BFUkxfVkVSU0lPTn0N
CiBQRVJMPQkJJHtMT0NBTEJBU0V9L2Jpbi9wZXJsDQogDQotLmVuZGlmICAj
IGRlZmluZWQoX1BFUkxfUkVGQUNUT1JJTkdfQ09NUExFVEUpDQotDQogIyBE
ZWNpZGUgd2hlcmUgdG8gbG9vayBmb3IgdGhlIHZlcnNpb24gc3RyaW5nDQog
LmlmZGVmIFVTRV9QRVJMNQ0KIFVTRV9QRVJMNV9TVFJJTkc9CSR7VVNFX1BF
Ukw1fQ0KQEAgLTE3NSwxNSArMTY5LDExIEBADQogDQogUGVybF9Qb3N0X0lu
Y2x1ZGU9CQlic2QucGVybC5taw0KIA0KLS5pZiBkZWZpbmVkKF9QRVJMX1JF
RkFDVE9SSU5HX0NPTVBMRVRFKQ0KLQ0KIFBMSVNUX1NVQis9CVBFUkxfVkVS
U0lPTj0ke1BFUkxfVkVSU0lPTn0gXA0KIAkJCVBFUkxfVkVSPSR7UEVSTF9W
RVJTSU9OfSBcDQogCQkJUEVSTF9BUkNIPSR7UEVSTF9BUkNIfSBcDQogCQkJ
U0lURV9QRVJMPSR7U0lURV9QRVJMX1JFTH0NCiANCi0uZW5kaWYgICMgZGVm
aW5lZChfUEVSTF9SRUZBQ1RPUklOR19DT01QTEVURSkNCi0NCiAuaWYgIWRl
ZmluZWQoUEVSTCkgfHwgIWRlZmluZWQoUEVSTDUpIHx8ICFkZWZpbmVkKFBF
UkxfUE9SVCkgfHwgIWRlZmluZWQoU0lURV9QRVJMKQ0KIElHTk9SRT0JCW1p
c3NpbmcgZGVmaW5lIGZvciBXQU5UX1BFUkwsIFVTRV9QRVJMNSwgb3Igc2lt
aWxhciBiZWZvcmUgYnNkLnBvcnQucHJlLm1rIGluY2x1c2lvbg0KIC5lbmRp
Zg0KSW5kZXg6IGJzZC5wb3J0Lm1rDQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
DQpSQ1MgZmlsZTogL2hvbWUvcGN2cy9wb3J0cy9Nay9ic2QucG9ydC5tayx2
DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjQzDQpkaWZmIC11IC1yMS42NDMg
YnNkLnBvcnQubWsNCi0tLSBic2QucG9ydC5tawkxNSBKdWwgMjAxMCAxNDo0
ODo1MCAtMDAwMAkxLjY0Mw0KKysrIGJzZC5wb3J0Lm1rCTI5IEp1bCAyMDEw
IDA2OjMwOjI4IC0wMDAwDQpAQCAtMTQ1MCw0NiArMTQ1MCw2IEBADQogDQog
UEtHQ09NUEFURElSPz0JCSR7TE9DQUxCQVNFfS9saWIvY29tcGF0L3BrZw0K
IA0KLSMgWFhYIHRvIHJlbWFpbiB1bmRlZmluZWQgdW50aWwgYWxsIHBvcnRz
IHRoYXQgcmVxdWlyZSBQZXJsIGFyZSBmaXhlZA0KLSMgdG8gc2V0IG9uZSBv
ZiB0aGUgY29uZGl0aW9uYWxzIHRoYXQgZm9yY2UgdGhlIGluY2x1c2lvbiBv
ZiBic2QucGVybC5taw0KLS5pZiAhZGVmaW5lZChfUEVSTF9SRUZBQ1RPUklO
R19DT01QTEVURSkNCi0NCi1QRVJMX1ZFUlNJT04/PQk1LjEwLjENCi0NCi0u
aWYgIWRlZmluZWQoUEVSTF9MRVZFTCkgJiYgZGVmaW5lZChQRVJMX1ZFUlNJ
T04pDQotcGVybF9tYWpvcj0JCSR7UEVSTF9WRVJTSU9OOkN8XihbMS05XSsp
Lip8XDF8fQ0KLV9wZXJsX21pbm9yPQkwMCR7UEVSTF9WRVJTSU9OOkN8Xihb
MS05XSspXC4oWzAtOV0rKS4qfFwyfH0NCi1wZXJsX21pbm9yPQkJJHtfcGVy
bF9taW5vcjpDfF4uKiguLi4pfFwxfH0NCi0uaWYgJHtwZXJsX21pbm9yfSA+
PSAxMDANCi1wZXJsX21pbm9yPQkJJHtQRVJMX1ZFUlNJT046Q3xeKFsxLTld
KylcLihbMC05XVswLTldWzAtOV0pLip8XDJ8fQ0KLXBlcmxfcGF0Y2g9CQkk
e1BFUkxfVkVSU0lPTjpDfF4uKiguLil8XDF8fQ0KLS5lbHNlICMgJHtwZXJs
X21pbm9yfSA8IDEwMA0KLV9wZXJsX3BhdGNoPQkwJHtQRVJMX1ZFUlNJT046
Q3xeKFsxLTldKylcLihbMC05XSspXC4qfDB8fQ0KLXBlcmxfcGF0Y2g9CQkk
e19wZXJsX3BhdGNoOkN8Xi4qKC4uKXxcMXx9DQotLmVuZGlmICMgJHtwZXJs
X21pbm9yfSA8IDEwMA0KLVBFUkxfTEVWRUw9CSR7cGVybF9tYWpvcn0ke3Bl
cmxfbWlub3J9JHtwZXJsX3BhdGNofQ0KLS5lbHNlDQotUEVSTF9MRVZFTD0w
DQotLmVuZGlmICMgIWRlZmluZWQoUEVSTF9MRVZFTCkgJiYgZGVmaW5lZChQ
RVJMX1ZFUlNJT04pDQotDQotUEVSTF9BUkNIPz0JCW1hY2gNCi0NCi0uaWYg
ICAgJHtQRVJMX0xFVkVMfSA+PSA1MDEyMDANCi1QRVJMX1BPUlQ/PQlwZXJs
NS4xMg0KLS5lbGlmICAke1BFUkxfTEVWRUx9ID49IDUwMTAwMA0KLVBFUkxf
UE9SVD89CXBlcmw1LjEwDQotLmVsc2UNCi1QRVJMX1BPUlQ/PQlwZXJsNS44
DQotLmVuZGlmDQotDQotU0lURV9QRVJMX1JFTD89CWxpYi9wZXJsNS9zaXRl
X3BlcmwvJHtQRVJMX1ZFUlNJT059DQotU0lURV9QRVJMPz0JJHtMT0NBTEJB
U0V9LyR7U0lURV9QRVJMX1JFTH0NCi0NCi1QRVJMNT0JCSR7TE9DQUxCQVNF
fS9iaW4vcGVybCR7UEVSTF9WRVJTSU9OfQ0KLVBFUkw9CQkke0xPQ0FMQkFT
RX0vYmluL3BlcmwNCi0NCi0uZW5kaWYgICMgIWRlZmluZWQoX1BFUkxfUkVG
QUNUT1JJTkdfQ09NUExFVEUpDQotDQogLmlmIGRlZmluZWQoVVNFX0xPQ0FM
X01LKQ0KIC5pbmNsdWRlICIke1BPUlRTRElSfS9Nay9ic2QubG9jYWwubWsi
DQogLmVuZGlmDQpAQCAtMjA0OSwxMyArMjAwOSw2IEBADQogDQogLmVuZGlm
DQogDQotLmlmICFkZWZpbmVkKF9QRVJMX1JFRkFDVE9SSU5HX0NPTVBMRVRF
KQ0KLVBMSVNUX1NVQis9CQlQRVJMX1ZFUlNJT049JHtQRVJMX1ZFUlNJT059
IFwNCi0JCQkJUEVSTF9WRVI9JHtQRVJMX1ZFUlNJT059IFwNCi0JCQkJUEVS
TF9BUkNIPSR7UEVSTF9BUkNIfSBcDQotCQkJCVNJVEVfUEVSTD0ke1NJVEVf
UEVSTF9SRUx9DQotLmVuZGlmICAjICFkZWZpbmVkKF9QRVJMX1JFRkFDVE9S
SU5HX0NPTVBMRVRFKQ0KLQ0KIC5pZiBkZWZpbmVkKFVTRV9MT0NBTF9NSykN
CiAuaW5jbHVkZSAiJHtQT1JUU0RJUn0vTWsvYnNkLmxvY2FsLm1rIg0KIC5l
bmRpZg0K
--0-2081216686-1280386054=:1718--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1007282321490.1718>