From owner-freebsd-ports@FreeBSD.ORG  Mon Jun 11 05:18:02 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C720F1065672
	for <ports@FreeBSD.org>; Mon, 11 Jun 2012 05:18:02 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A8F818FC0C;
	Mon, 11 Jun 2012 05:18:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5B5I2Qh084048;
	Mon, 11 Jun 2012 05:18:02 GMT (envelope-from bapt@FreeBSD.org)
Received: (from bapt@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5B5I2IS084047;
	Mon, 11 Jun 2012 05:18:02 GMT (envelope-from bapt@FreeBSD.org)
X-Authentication-Warning: freefall.freebsd.org: bapt set sender to
	bapt@FreeBSD.org using -f
Date: Mon, 11 Jun 2012 07:17:59 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Warren Block <wblock@wonkity.com>
Message-ID: <20120611051759.GQ60433@ithaqua.etoilebsd.net>
References: <alpine.BSF.2.00.1206101408330.77586@wonkity.com>
	<f5dc8813da21631bff52d1017bcd6dcf.squirrel@mail.experts-exchange.com>
	<alpine.BSF.2.00.1206101736170.78656@wonkity.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="l8yJEXo8J9fv7OFY"
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.1206101736170.78656@wonkity.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: ports@FreeBSD.org, Jason Helfman <jhelfman@e-e.com>
Subject: Re: NOPORTDOCS and NOPORTEXAMPLES
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2012 05:18:02 -0000


--l8yJEXo8J9fv7OFY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 10, 2012 at 06:05:49PM -0600, Warren Block wrote:
> On Sun, 10 Jun 2012, Jason Helfman wrote:
>=20
> >> So references to NOPORTDOCS should be replaced with references to
> >> PORT_OPTIONS:MDOCS now?  Why that but not NOPORTEXAMPLES?
> >
> > You can use PORT_OPTIONS:MEXAMPLES for this case.
> >
> > I believe I did this recently in www/flot
>=20
> But only after bsd.port.options.mk is included.  Here's what I was=20
> trying to do:
>=20
> .if ${PORT_OPTIONS:MDOCS}
> OPTIONS_DEFINE+=3D        REFDOCS
> REFDOCS_DESC=3D           Install the reference documents
> OPTIONS_DEFAULT+=3D       REFDOCS
> .endif
>=20
> .if ${PORT_OPTIONS:MEXAMPLES}
> OPTIONS_DEFINE+=3D        EXAMPLES
> EXAMPLES_DESC=3D          Install the example code
> OPTIONS_DEFAULT+=3D       EXAMPLES
> .endif
>=20
> .include <bsd.port.options.mk>
>=20

Why not simply that way:

OPTIONS_DEFINE=3D	... DOCS EXAMPLES

DOCS_DESC=3D	Install the reference documents

And done.

Condtion an EXAMPLES on EXAMPLES options doesn't make sense to me.

by default DOCS and EXAMPLES are on expect if the user set NOPORTDOCS,
NOPORTEXAMPLES or OPTIONS_UNSET=3D DOCS EXAMPLES

regards,
Bapt

--l8yJEXo8J9fv7OFY
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk/Vf4cACgkQ8kTtMUmk6EyxRgCgm799XIMHh4HqeAT/8kMZ0t8D
+GsAoLkN4GIVfj5vOSBa30sIXxTPluWa
=K4e/
-----END PGP SIGNATURE-----

--l8yJEXo8J9fv7OFY--