From owner-freebsd-bugs@freebsd.org Fri Sep 9 19:02:13 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11243BD4FF0 for ; Fri, 9 Sep 2016 19:02:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 00BE2FC1 for ; Fri, 9 Sep 2016 19:02:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u89J2CRo015283 for ; Fri, 9 Sep 2016 19:02:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211823] [patch] fsck_ffs incorrectly failing in check_cgmagic Date: Fri, 09 Sep 2016 19:02:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 19:02:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211823 Kirk McKusick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mckusick@FreeBSD.org --- Comment #7 from Kirk McKusick --- Given that your value of cgp->cg_old_niblk is > 2^15 says that at least und= er OpenBSD the declaration of cgp->cg_old_niblk as int16_t is wrong. Rather it should be declared as uint16_t. So it seems to me that the correct solution here is to change the declaration of cgp->cg_old_niblk to be uint16_t as it should. This change should not break any existing filesystems. As to the question of compatibility of OpenBSD's UFS to that of FreeBSD, we have managed to do that so far. So, I am in favor of keeping them compatible (at least for small changes such as this one). --=20 You are receiving this mail because: You are the assignee for the bug.=