From owner-freebsd-hackers@FreeBSD.ORG Mon May 28 03:06:22 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A0D53106566B for ; Mon, 28 May 2012 03:06:22 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id 497EB8FC08 for ; Mon, 28 May 2012 03:06:22 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:content-type :content-transfer-encoding; q=dns; s=sweb; b=IlhUR7Z2p/QwlHKc4jU pirHLQhMydRiQdOqM7lwd1dYUFPMzFFmORaJyLgMtGOuOnR5SWKAQV7Bfqulogot JIcasWDc+Fs6m87AB/+lr1pXbbr4Xn9B7SHWv4vBG2kttDIxbyX+KWQ1o15xaD79 9PpE/ivqm3t2kNU0u1qv4iDw= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:content-type :content-transfer-encoding; s=sweb; bh=LXlgLqLmreSR0iBWOMCotFjMu 0i0sthGH+D9sDlXvW0=; b=c39vgskNXAPPOuciAHI3ZOYXfozJEvtFZjNxE21da YIRxQdU2+goTEf6eOMfUf1XzIaYP5eHzO8xJ1OVC0woVSneuFksXi6Ec5Ch36yNa e2olFxbciJbWBpfL+3yNNfKXHvvXzLBeonEvnbVMKcKe+n+Yba/UMf2jq5BXtW5M AU= Received: (qmail 15696 invoked from network); 27 May 2012 22:06:14 -0500 Received: from unknown (HELO ?10.10.1.87?) (bryan@shatow.net@10.10.1.87) by sweb.xzibition.com with ESMTPA; 27 May 2012 22:06:14 -0500 Message-ID: <4FC2EBA5.8010500@shatow.net> Date: Sun, 27 May 2012 22:06:13 -0500 From: Bryan Drewery User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org X-Enigmail-Version: 1.4.1 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ed@80386.nl, brucec@freebsd.org Subject: script(1) broken on 7.4 - bin/146189 - r207453 fixes X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2012 03:06:22 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, As reported in bin/146189, script(1) was returning the wrong exit status sometimes. The PR says that script(1) was broken by r205008/r205635, neither of which are in 7-stable or releng/7.4. Yet it is broken on 7.4. This is easily seen on 7.4: # script -q /dev/null false; echo $? 1 # script -q /dev/null false; echo $? 1 # script -q /dev/null false; echo $? 0 # script -q /dev/null false; echo $? 1 # while true; do script -q /dev/null false && echo $? && break; echo $?; done 1 1 <..snip..> 1 0 r207453 was MFC'd to 8-stable at the time, but not 7-stable, likely due to the changes attributed to causing the issue not having been on 7-stable. I am not entirely sure *how* script(1) broke on 7.4, but I have tested r207453 on 7.4 and found that it Works For Me. FWIW, could someone please MFC this to 7-stable? The reason I ran into this is I am maintaining portupgrade, and working on ports/147242 and ports/131111. Both of which seem to be due to script(1) returning the wrong exit status. 7.x is EoL Feb 2013 [1]. Given that, and that script(1)'s return code cannot be relied on for automated scripts. I am wondering what the thoughts are on putting this patch out as an errata? Regards, Bryan Drewery [1] http://www.freebsd.org/security/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPwuukAAoJEG54KsA8mwz5OqEP/38GQcmgBFRbAsNXtOfYOIO0 aPNQTNBsR6VT52VDDKxU7Ou6zL3RlVoL8A9hxlYSXjLdRLDwP6TUODSyNGlsDbSd +o7LVN8VGEHEEflcM0lYEiQEfOhJFBwqBhvVs6Efm7USKwnumGfTnLnkMTXDzwtb RoTQnJDh8wv219Tg71f/RoBhemY6da0Rr7teOB99q22guIc8ao2fnTTcpvhJtg1b l6WwN9O41MQNy3mniC9B0JdxU4Nl8/KQg1PHQMfUR+Q+L0OPcXXSW20NqzmTT41/ RcC4xINgX/y6OHOt3YcVTIKvclwUKxgPYXrIspfEltnwKHpm3SP+gV0O4MLcYTyQ kZkQSA/vIaVRCNY90jwRFa7Pmxj4u7Fqh2l0Cxh87XC2l2JvUtXm/u+bbegJRWzp M27LUjm6FArvC6SNpn3wEWCaY7J7o8fFLTZTMA2PcU7lKPqalIIdrTcug2eUYSye Wcax2OUfhhnH4Dtc59lb243eMDj//zb3q/wXBhMQFZhZXMcNF6P7lh6Z6edSMMDG Wi71VK+dSJdCeXo179W3jztcj6ZnY+DUvkAnLPdxJR58xgjDTVIPJFogkYEnc+pJ qWELKYh5Z/MAbckAaLWSi4nVmdQve6bBYI0Amgxz8/ilciV1NAkNKZOHPVKaOY/7 4NPnCKV1Uqj6u2tHZYOF =a33b -----END PGP SIGNATURE-----